Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: FS#10849 - Sleep timer options: persistent duration and start on boot

Re: FS#10849 - Sleep timer options: persistent duration and start on boot

From: Frank Gevaerts <frank_at_gevaerts.be>
Date: Sun, 14 Aug 2011 02:48:48 +0200

On Sun, Aug 14, 2011 at 01:05:38AM +0200, sideral wrote:
> I'd like to commit FS#10849

I don't use the sleep timer myself (in fact, I think I never even tried
it), so I'm not sure how much my opinion is worth here.

I think that the patch adds real functionality that's hard to achieve by
other (existing) means, and I don't really believe that the new options
can be considered a regression for any use case. Moreover, my impression
is that the new functionality is wanted by a fair amount of users.

I haven't looked at the actual implementation, but it's a fairly small
patch that doesn't touch the sort of code that's rumoured to harbour
dragons, so I think we can trust the judgement of whoever commits it
as far as quality is concerned.

Frank

-- 
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan
Received on 2011-08-14

Page was last modified "Jan 10 2012" The Rockbox Crew
aaa