On Mon, Aug 15, 2011 at 6:11 AM, Thomas Martitz <kugel_at_rockbox.org> wrote:
> In fact, I thought about it a bit more and also came up with a proposal
> that makes sense to me. It is similar to the first in FS#10849, except that
> I find the "Sleep Timer Duration" item redundant. What I would prefer is to
> have two menu items (actually one, since I actually don't see the point in
> applying the sleep timer on boot):
> Settings -> Time & Date:
> - Set sleep timer: If inactive, then set the time and start the sleep
> timer (the initial time would be remembered, i.e. persistent). If active,
> then it transforms to "Stop sleep timer" which just cancels the current
> sleep timer and transforms back to "Set sleep timer".
> - Start sleep timer on boot: yes/no.
A small recap to make sure I'm on the same page.
The use case for this patch appears to be when someone is listening to
something long (e.g. an audiobook) and isn't sure if they will fall asleep
before the timer shuts the player off. Presently, If they are still awake,
resetting the sleep timer requires setting up the sleep timer again from
scratch. This patch addresses the issue by creating a persistent sleep
timer. It does so by adding a couple more settings. It also makes it a
little harder to change the value of the sleep timer, since two setting have
to be changed.
What about adding one new setting that let you chose whether you wanted to
persistently set the last sleep value every time you turned on the player.
If you chose to activate that setting, whatever the last sleep timer was set
to would start again when the player was turned on again.
This would leave the present sleep setting unaffected. You could use it as
you've always used it. The added functionality is that if you enable the
persistent setting, all you have to do to reactivate the timer with the last
value used it turn the player back on.
If you find you want to disable the timer while the persistent option is
set, just go into the timer menu and set it to 0. The next time you reboot
the player it will still be disabled, since that was the last setting.
I think this is a simple solution that addresses the questions raised in
this thread. Did I miss anything? Is this what Thomas Martinez is suggesting
in different words?
Received on 2011-08-15