Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: RE: Git/gerrit migration status and next steps

RE: Git/gerrit migration status and next steps

From: Bertrik Sikken <bertrik_at_sikken.nl>
Date: Wed, 7 Sep 2011 09:58:50 +0200

>> Do we really want to allow commits directly? so little of our code ever
>> gets
>> reviewed so I would quite happily force everyone to go through gerrit
>> and
>> require someone else to OK it. It isnt hard to get someone else in IRC
>> to have
>> a quick look and push the button.
>
> Absolutely against requiring this.
>
> We trust committers to do "the right thing".
>
> If you have a patch you think needs this - submit to refs/for/master.
>
> For small commits, this would be a completely pain in the arse, and
> totally unwarranted.

I'm with Bryan on this.

If a policy like this is implemented development would be a lot less fun
for me and I'd not be as motivated to work on rockbox at all.

Kind regards,
Bertrik
Received on 2011-09-07


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa