Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: jdgordon: r30599 - in trunk/apps: . gui/skin_engine

Re: jdgordon: r30599 - in trunk/apps: . gui/skin_engine

From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Wed, 5 Oct 2011 18:44:01 +1100

On 5 October 2011 18:19, Thomas Martitz <kugel_at_rockbox.org> wrote:
> Am 28.09.2011 09:00, schrieb Thomas Martitz:
>>
>> TBH, I would like to revert this commit.
>>
>> Best regards.
>>
>
> Alright, as a few people agreed with me I'm going to revert this in a few
> hours.
>
> Best regards.
>
>

Go ahead, just remember you're then responsible for breaking users
ability to load their otherwise working themes. Frankly the 2 users
whom I've personally helped trumps your (very likely personal) reasons
against the change.

Heck, read the thread, you're the only one who has said anything about
the actual feature, everyone else just doesnt like the implementation
(myself included to be completely honest). But unless you're going to
do something about the apparent ram waste, or reimplement this is a
nicer way, then you reverting is just a dick thing to do.

Best regards to you too :)

Jonathan
Received on 2011-10-05


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa