|
|
Rockbox mail archiveSubject: Re: Trimming the lcd apiRe: Trimming the lcd api
From: Björn Stenberg <bjorn_at_haxx.se>
Date: Wed, 12 Oct 2011 22:19:08 +0200
Thomas Martitz wrote:
Having both lcd_puts and lcd_putsf gives no advantage, on arm anyway. A call to lcd_putsf() with only the fmt parameter produces identical code as a call to lcd_puts():
void argtest(void)
000040c4 <argtest>:
However there is certainly a point in not requiring all arguments all the time, so two functions make sense. Since they are vararg enabled, I'd say a more suitable name than lcd_puts is lcd_printf and its extended companion lcd_xprintf.
-- BjörnReceived on 2011-10-12 Page was last modified "Jan 10 2012" The Rockbox Crew |