Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: dreamlayers: r31296 - in trunk/apps: . metadata

Re: dreamlayers: r31296 - in trunk/apps: . metadata

From: Boris Gjenero <boris.gjenero_at_gmail.com>
Date: Thu, 15 Dec 2011 20:09:06 -0500

On 15/12/11 06:04 PM, Jonathan Gordon wrote:
> This is exactly what we don't want to do!
>
> On 16 December 2011 07:58,<mailer_at_svn.rockbox.org> wrote:
>> Date: 2011-12-15 21:58:14 +0100 (Thu, 15 Dec 2011)
>> New Revision: 31296
>>
>> Log Message:
>> Add conditionals for functions only needed on SWCODEC targets.

Sorry, I guess I should have waited until there's some decision on
whether to fork HWCODEC. I thought it was fine because this is
straightforward and not "#ifdef hell".

BTW. Another function unused on HWCODEC is thread_thaw(). I didn't
address that one in the patch because it's more complicated. There's
also no need to create frozen threads, and because of that there's no
need for the flags parameter to create_thread(). This latter part is
also an example of where -ffunction-sections can't completely remove
unused code.

Regards,

Boris
Received on 2011-12-16


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa