Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Classic holdswitch polling

Re: Classic holdswitch polling

From: Marcin Bukat <marcin.bukat_at_gmail.com>
Date: Thu, 8 Mar 2012 08:52:46 +0100

> Why do you consider this a hack? And why should other targets where key
> reading is simple and fast (i.e. nice) in ISR suffer only due to the
> classic?

Could you elaborate the term 'suffer' in this context?

> FWIW, targets can do what they want. The button tick only calls
> button_read_device(). That can read the HW or read some global variable or
> whatever other way is best for the target. How do you want to "move
> keyreading off ISR" there?

Tick tasks are run from ISR. There is absolutely no need to read keys
in ISR IMO, reading in ISR gives no benefits in this case.
Changing the behavior for only one target while there are no technical
barriers to do this consistently on all targets is a hack in my
nomenclature.

MB
Received on 2012-03-08


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa