Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: re FS#12625 - Sleep timer setting is broken

re FS#12625 - Sleep timer setting is broken

From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Wed, 28 Mar 2012 00:20:37 +1100

Hi,

This wasnt caught when the sleep timer changes were commited, and its
not really a big deal but it should be changed.

IIUC the sleep timer is now broken into a few different settings:
1) set timer on boot
2) restart timer on keypress
3) start the timer with the chosen minutes value (arbitrarily set to
5min increments).

Both the first two settings use the 3rd to know how long to start the
timer for manually. The issue in the task is:
1) It isnt a normal setting so cant be added to the quickscreen and
shortcuts menu (minor inconvinience)
2) cancelling the setting screen enables the timer anyway. - BAD!

I don't understand why setting the sleep timer duration for boot
should be linked to the sleep timer duration i want to set
temporarily. (i.e the current system means unless I have a fixed.cfg
it is impossible for me to set a 30min timer before i go to bed and
have it turn on with a 90min timer).

The duration should be a separate setting and the "start sleep timer"
menu item should then be changed to start at "off" so pressing cancel
will not enable a timer.
In addition, extra handling for the sleep timer can be manually added
to the shortcuts screen to start/stop a timer.

Jonathan.
Received on 2012-03-27


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa