From: Frank Gevaerts via rockbox-dev <rockbox-dev_at_cool.haxx.se>
Date: Thu, 10 Dec 2015 16:44:41 +0100

On Thu, Dec 10, 2015 at 12:06:33AM +0000, Amaury Pouly via rockbox-dev wrote:
> >
> > Now that we have the PIDs, it's time to assign them to targets. The
> > current plan is to allocate all the stable targets and some of the
> > in-development ones (e.g. ipod6g) a unique PID, and all the rest a "generic
> > rockbox device" PID.
> >
> Since each target is going to have two potential IDs (OF and Rockbox), I
> think it raises the question of which one to choose. I suggest we add a
> setting to choose between OF and Rockbox assigned IDs, and maybe even
> provide support from custom IDs if this feature is wanted. The default
> choice should be OF at least for all existing targets, I don't know what it
> should be for newer ones, perhaps still OF to avoid confusion ?

I'm not that convinced the OF IDs should be the default. They are of
course familiar, and some people might have set up special handling for
their devices which makes changing a bit awkward, but we also have seen
issues on all sorts of devices where various OSes and host-based
software makes assumptions based on those IDs which then turn out to
cause problems.

Frank

-- 
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan

Received on 2015-12-10