Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10014 - Separate tracklocking out of skip length

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Thursday, 12 March 2009, 19:19 GMT+2
Last edited by Nils Wallménius (nls) - Saturday, 28 March 2009, 09:27 GMT+2
Task Type Patches
Category Music playback
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch implements the idea that came up here: http://forums.rockbox.org/index.php?topic=20739.0

Read the topic for my reasonings, why I made this patch.

Short summary: It separates the tracklock feature of skip length out to a seperate setting, so that skip length is actually usable too for normal music playback.

One note: It does NOT prevent track changing due to normal playback (i.e. when the current track ends). For this, you'll want to combine with Repeat: One (this gives more flexibility to the setting too).

This patch doesn't change how tracklock works, it really just seperates the setting (e.g. the above also happens with the current skip length).
   rockbox-tracklock.v1.diff (5.9 KiB) 
 apps/lang/english.lang     |   14 ++++++++++++
 apps/gui/gwps-common.c     |   31 ---------------------------
 apps/gui/gwps-common.h     |    1 
 apps/gui/gwps.c            |   50 +++++++++++++++++++++++++++++++++++++++++++--
 apps/settings.h            |    1 
 apps/menus/playback_menu.c |    3 +-
 apps/settings_list.c       |    1 
 7 files changed, 66 insertions(+), 35 deletions(-)

This task depends upon

Closed by  Nils Wallménius (nls)
Saturday, 28 March 2009, 09:27 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  kugel committed this as r20553
Comment by Thomas Martitz (kugel.) - Friday, 13 March 2009, 05:25 GMT+2
Sync'd. Also, remove the the keycombos that were there for skipping tracks within skip length mode, which are (I think) not needed anymore.
   rockbox-tracklock.v1b.diff (5.5 KiB) 
 apps/lang/english.lang     |   14 ++++++++++++++
 apps/gui/gwps.c            |   41 +++++++++++++++++++++--------------------
 apps/settings.h            |    1 +
 apps/menus/playback_menu.c |    3 ++-
 apps/settings_list.c       |    1 +
 5 files changed, 39 insertions(+), 21 deletions(-)

Loading...