Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10028 - Move Tremor block pcm (double-buffer) into IRAM for big speedup

Attached to Project: Rockbox
Opened by Dave Hooper (stripwax) - Tuesday, 17 March 2009, 02:11 GMT+2
Last edited by Nils Wallménius (nls) - Saturday, 21 March 2009, 16:24 GMT+2
Task Type Patches
Category Codecs
Status Closed
Assigned To No-one
Player Type iPod 5G
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Putting the block pcm buffer (libtremor/block.c) into iram (rather than using the ogg_calloc stuff) gives a speedup of about 15MHz on some test vorbis files around q5 - from around 45MHz (according to buffering thread debug) to around 30MHz - using a regular 30MHz clock that would mean almost never having to boost. Using a default 24MHz clock I get a boost ratio of around 11% now.

Attached is one way to do this which works for ipod 5g (other targets untested, suspect many targets may not have sufficient iram to allow for BOTH the block.c pcm buffer and the existing synthesis.c pcm buffer)
   libtremor.patch (3 KiB) 
 block.c |   40 +++++++++++++++++++++++++++++-----------
 1 file changed, 29 insertions(+), 11 deletions(-)

This task depends upon

Closed by  Nils Wallménius (nls)
Saturday, 21 March 2009, 16:24 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  Closed on request by the poster.
Thanks for looking into this!
Comment by Dave Hooper (stripwax) - Tuesday, 17 March 2009, 02:28 GMT+2
Seems I was hasty in my assessment (and can only assume I measured very badly) - test_codec never lies
Before
After
Still, despite marginal improvement, any reason to not commit [after changes to ensure works on all platforms]?
   test_codec_log_01.txt (0.7 KiB)
   test_codec_log_07.txt (0.7 KiB)
Comment by Nils Wallménius (nls) - Thursday, 19 March 2009, 16:43 GMT+2
hi, this patch seems to be doing part of what  FS#9882  does
Comment by Dave Hooper (stripwax) - Saturday, 21 March 2009, 16:18 GMT+2
Part of it, although that patch doesn't seem to put the vorbis dsp buffer into iram, just the block dsp buffer.
Anyway, as discussed on irc (on 17th), my patch is certainly better folded into  FS#9882  in any case. I'm looking at doing a combination of the following things (and will post on  FS#9882  instead of here)
put dsp buffer into iram too
get rid of need for memcpy ("vect_copy") step

 FS#10028  can be closed

Loading...