Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10043 - lcd_e200v2 updates

Attached to Project: Rockbox
Opened by Michael Chicoine (mc2739) - Sunday, 22 March 2009, 22:54 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Friday, 10 April 2009, 03:44 GMT+2
Task Type Patches
Category LCD
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch for the e200v2 cleans up unused GPIOs and implements LCD flipping and invert.
   lcd-e200v2.diff (4.4 KiB) 
 firmware/target/arm/as3525/sansa-e200v2/lcd-e200v2.c |   59 ++++++++++++-------
 1 file changed, 38 insertions(+), 21 deletions(-)

This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Friday, 10 April 2009, 03:44 GMT+2
Reason for closing:  Accepted
Comment by Thomas Martitz (kugel.) - Monday, 23 March 2009, 19:05 GMT+2
I'll look if it works on the fuze too!

Please do not use fixed numbers like 0xaf or 0xdb, but LCD_WIDTH/_HEIGHT (-1) instead.
Comment by Michael Chicoine (mc2739) - Tuesday, 24 March 2009, 01:00 GMT+2
Here is a new version with LCD_WIDTH-1 and LCD_HEIGHT-1 instead of fixed numbers.
   lcd-e200v2-v2.diff (4.4 KiB) 
 firmware/target/arm/as3525/sansa-e200v2/lcd-e200v2.c |   59 ++++++++++++-------
 1 file changed, 38 insertions(+), 21 deletions(-)

Comment by Michael Chicoine (mc2739) - Friday, 27 March 2009, 01:51 GMT+2
Version 3 adds code to put lcd in standby to reduce power consumption.
   lcd-e200v2-v3.diff (4.6 KiB) 
 firmware/target/arm/as3525/sansa-e200v2/lcd-e200v2.c |   61 ++++++++++++-------
 1 file changed, 39 insertions(+), 22 deletions(-)

Comment by Maurus Cuelenaere (mcuelenaere) - Friday, 27 March 2009, 10:50 GMT+2
You can remove the '(void)yesno;' line (this is just to fix warnings when the parameter doesn't get used).
Comment by Michael Chicoine (mc2739) - Friday, 27 March 2009, 12:39 GMT+2
Additional cleanup - removed '(void)yesno;' and unused function flip_lcd()
   lcd-e200v2-v4.diff (4.7 KiB) 
 firmware/target/arm/as3525/sansa-e200v2/lcd-e200v2.c |   67 ++++++++++---------
 1 file changed, 37 insertions(+), 30 deletions(-)

Comment by Andreas Langmann (cyclon1978) - Tuesday, 31 March 2009, 14:00 GMT+2
works fine on e280
Comment by MichaelGiacomelli (saratoga) - Tuesday, 07 April 2009, 18:29 GMT+2
Is this ready to commit?
Comment by Michael Chicoine (mc2739) - Tuesday, 07 April 2009, 19:24 GMT+2
I believe so. I have not seen any problems caused by this patch.

Loading...