Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10070 - rework TTS and Encoders in rbutil, to better seperate the gui

Attached to Project: Rockbox
Opened by Dominik Wenger (Domonoky) - Sunday, 29 March 2009, 20:06 GMT+2
Last edited by Dominik Wenger (Domonoky) - Wednesday, 29 April 2009, 23:30 GMT+2
Task Type Patches
Category Rbutil
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details


This is the first attempt to better seperate the configuration Gui from the TTS and Encoders in Rbutil. The TTS and Encoders present now a Model, which can be displayed via a generic TableView.

This patch is nearly ready, but it still needs some improvements. Also i am not sure about the Gui. Is it enough to present the options in a Table like this, or do we need something better ?

Please try it and comment here.
   rbutil-ttsEnc-rework-v1.path (94.2 KiB)
This task depends upon

Closed by  Dominik Wenger (Domonoky)
Wednesday, 29 April 2009, 23:30 GMT+2
Reason for closing:  Accepted
Comment by Dominik Riebeling (bluebrother) - Sunday, 29 March 2009, 23:33 GMT+2
Got it crashed almost instantly:
- go to the configuration, select festival (note: festival isn't installed on my system)
- use Configure TTS, then Voice
The dialog hangs in an endless loop. Also, the table view is poorly layed out -- some lines are much bigger than other without containing more information at all which looks crappy. Also, I'm not sure if I like the table view at all...

Haven't checked the code (yet) though.
Comment by Dominik Wenger (Domonoky) - Monday, 30 March 2009, 18:50 GMT+2
Just as a note:
Festival is the one i didnt really test, as its not available on windows for now. But it shoudnt crash ofcourse :-) I will try to reproduce and test this later.

I also noticed this strange thing, where some lines in the TableView are bigger then others, (only if there are more then 2 Buttons) but it didnt want to spend too much time on this for now. (I probably just have to setup the Table View correctly). But i am with you, that the Table View itself isnt perfect, does anyone have a better Idea for a !generic! setting view ?

Ofcourse for now, the Code changes is what is important.. any comments ? :-)
Comment by Dominik Wenger (Domonoky) - Thursday, 02 April 2009, 23:17 GMT+2
Another attempt:

This time it has a dynamically generated ui, with seperate Gui elements, which should look much nicer :-)

Also i think the code looks much cleaner now. Please comment.

Screenshots:
http://imagebin.ca/view/llIivM04.html
http://imagebin.ca/view/PBqC8uoi.html
http://imagebin.ca/view/2FnlkDnV.html
   rbutil-ttsEnc-rework-v2.path (88.3 KiB)
Comment by Dominik Wenger (Domonoky) - Friday, 03 April 2009, 20:30 GMT+2
new Version:
- improved Code for better readability and more Comments
- fix configuration Dialog for Festival.

I think this patch is now nearly finished. So please comment
   rbutil-ttsEnc-rework-v3.patch (93 KiB) 
 rbutil/rbutilqt/encoders.cpp          |   98 ++++-----
 rbutil/rbutilqt/encexescfgfrm.ui      |  158 --------------
 rbutil/rbutilqt/ttsgui.cpp            |  339 --------------------------------
 rbutil/rbutilqt/rbsettings.cpp        |    2 
 rbutil/rbutilqt/encoders.h            |   80 ++++---
 rbutil/rbutilqt/ttsfestivalcfgform.ui |  322 ------------------------------
 rbutil/rbutilqt/encodersgui.h         |   79 -------
 rbutil/rbutilqt/configure.cpp         |    8 
 rbutil/rbutilqt/encttssettings.h      |  131 ++++++++++++
 rbutil/rbutilqt/encttscfggui.h        |   78 +++++++
 rbutil/rbutilqt/encodersgui.cpp       |  171 ----------------
 rbutil/rbutilqt/tts.cpp               |  293 +++++++++++++++------------
 rbutil/rbutilqt/ttsexescfgfrm.ui      |  158 --------------
 rbutil/rbutilqt/encttssettings.cpp    |   70 ++++++
 rbutil/rbutilqt/rbutilqt.pro          |   13 -
 rbutil/rbutilqt/encttscfggui.cpp      |  360 ++++++++++++++++++++++++++++++++++
 rbutil/rbutilqt/tts.h                 |  139 ++++++++-----
 rbutil/rbutilqt/ttsgui.h              |  104 ---------
 rbutil/rbutilqt/base/utils.cpp        |   29 ++
 rbutil/rbutilqt/base/utils.h          |    1 
 20 files changed, 1030 insertions(+), 1603 deletions(-)

Comment by Dominik Wenger (Domonoky) - Saturday, 04 April 2009, 14:20 GMT+2
Some more code cleanup. Make sure to always set a proper parent, so Qt Object handling works.

I think this patch is now nearly ready for commit. but should perhaps wait till after the next rbutil release.
   rbutil-ttsEnc-rework-v4.patch (99.2 KiB) 
 rbutil/rbutilqt/encoders.cpp          |  106 ++++-----
 rbutil/rbutilqt/encexescfgfrm.ui      |  158 --------------
 rbutil/rbutilqt/ttsgui.cpp            |  339 -------------------------------
 rbutil/rbutilqt/rbsettings.cpp        |    2 
 rbutil/rbutilqt/encoders.h            |   84 +++++--
 rbutil/rbutilqt/ttsfestivalcfgform.ui |  322 ------------------------------
 rbutil/rbutilqt/encodersgui.h         |   79 -------
 rbutil/rbutilqt/configure.cpp         |   30 ++
 rbutil/rbutilqt/createvoicewindow.h   |    2 
 rbutil/rbutilqt/encttssettings.h      |  129 ++++++++++++
 rbutil/rbutilqt/encttscfggui.h        |   78 +++++++
 rbutil/rbutilqt/encodersgui.cpp       |  171 ----------------
 rbutil/rbutilqt/tts.cpp               |  301 +++++++++++++++-------------
 rbutil/rbutilqt/voicefile.h           |    2 
 rbutil/rbutilqt/ttsexescfgfrm.ui      |  158 --------------
 rbutil/rbutilqt/createvoicewindow.cpp |    4 
 rbutil/rbutilqt/encttssettings.cpp    |   70 ++++++
 rbutil/rbutilqt/rbutilqt.pro          |   13 -
 rbutil/rbutilqt/encttscfggui.cpp      |  361 ++++++++++++++++++++++++++++++++++
 rbutil/rbutilqt/talkfile.h            |    2 
 rbutil/rbutilqt/voicefile.cpp         |    4 
 rbutil/rbutilqt/installtalkwindow.cpp |    4 
 rbutil/rbutilqt/tts.h                 |  141 ++++++++-----
 rbutil/rbutilqt/ttsgui.h              |  104 ---------
 rbutil/rbutilqt/base/utils.cpp        |   29 ++
 rbutil/rbutilqt/base/utils.h          |    1 
 rbutil/rbutilqt/talkfile.cpp          |    4 
 27 files changed, 1069 insertions(+), 1629 deletions(-)

Loading...