Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10075 - FUZE: QUIT Plugin by selecting BUTTON_HOME

Attached to Project: Rockbox
Opened by Johannes Schwarz (Ubuntuxer) - Monday, 30 March 2009, 20:42 GMT+2
Last edited by Thomas Martitz (kugel.) - Friday, 10 April 2009, 19:29 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

It makes more sense to use BUTTON_HOME instead of the current BUTTON_POWER to quit a plugin, because BUTTON_POWER is alongside the player. In the orginal firmware the button is also just scheduled for switch off.

In the following week I'll write a patch for the plugins.
This task depends upon

Closed by  Thomas Martitz (kugel.)
Friday, 10 April 2009, 19:29 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r20680. Thank you!
Comment by Johannes Schwarz (Ubuntuxer) - Tuesday, 31 March 2009, 14:53 GMT+2
I have written a patch, which changes the button in addition to the fuze also in the clip, because there's the same button. I haven't change the buttons in spacerocks, solitaire and blackjack, because the BUTTON_HOME is used for something else there. The problem is that this games doesn't have a menu, so key sequence of buttons are used to restart for example a game. This isn't very user friendly. It would be much better to have menu for this plugins. I think it wouldn't be much effort.
   fuze_clip_button.patch (62.5 KiB) 
 battery_bench.c         |   11 ++-
 beatbox/beatbox.c       |    8 ++
 blackjack.c             |    7 --
 bounce.c                |  165 ++----------------------------------------------
 brickmania.c            |   51 ++++++--------
 calculator.c            |   32 +++++----
 calendar.c              |   24 ++++++
 chessclock.c            |   15 +++-
 chopper.c               |   10 ++
 cube.c                  |   22 +++++-
 dict.c                  |    7 --
 fireworks.c             |    5 -
 flipit.c                |   13 ++-
 goban/goban.h           |    8 +-
 invadrox.c              |   10 ++
 jewels.c                |   22 +++++-
 jpeg/jpeg.h             |    5 -
 lamp.c                  |    3 
 lib/pluginlib_actions.c |   11 ++-
 logo.c                  |   12 ++-
 mandelbrot.c            |    6 -
 matrix.c                |    8 ++
 minesweeper.c           |   20 ++++-
 mosaique.c              |   10 ++
 oscilloscope.c          |   12 +--
 pacbox/pacbox.h         |    2 
 pegbox.c                |   14 +---
 plasma.c                |   10 ++
 pong.c                  |   13 ++-
 reversi/reversi-gui.h   |   14 +++-
 robotfindskitten.c      |    5 -
 rockblox.c              |    8 +-
 rockblox1d.c            |    9 +-
 rockboy/rockboy.c       |    4 -
 rockpaint.c             |    8 --
 sliding_puzzle.c        |   16 ----
 snake.c                 |   13 ++-
 snake2.c                |   19 ++++-
 snow.c                  |    6 -
 sokoban.c               |   21 ------
 star.c                  |   18 ++++-
 starfield.c             |   13 ++-
 stats.c                 |    8 --
 stopwatch.c             |    9 ++
 superdom.c              |   18 ++++-
 viewer.c                |    8 +-
 wormlet.c               |    6 -
 xobox.c                 |    5 -
 zxbox/zxbox_keyb.c      |   14 ++--
 49 files changed, 391 insertions(+), 367 deletions(-)

Comment by Rafaël Carré (funman) - Wednesday, 01 April 2009, 13:25 GMT+2
tested on clip : the behaviour is not consistent with the menu (power still exits the menu)
Comment by Johannes Schwarz (Ubuntuxer) - Thursday, 02 April 2009, 23:02 GMT+2
I have reworked the patch and deleted the changes on the buttons from the clip. I have tested it elaborately, so it should work well, now.
   fuze_button.patch (45.6 KiB) 
 battery_bench.c         |    9 +++++++--
 blackjack.c             |    2 +-
 bounce.c                |   11 +++++++++--
 brickmania.c            |   16 ++++++++++++++--
 calculator.c            |   31 ++++++++++++++++++++++---------
 calendar.c              |   13 +++++++++++--
 chessbox/chessbox_pgn.h |    2 +-
 chessclock.c            |   13 +++++++++++--
 chopper.c               |    8 ++++++--
 cube.c                  |   13 +++++++++++--
 dict.c                  |    3 +--
 doom/i_video.c          |    8 ++++----
 fireworks.c             |    2 +-
 flipit.c                |    2 +-
 goban/goban.h           |    4 ++--
 invadrox.c              |   10 ++++++++--
 jewels.c                |   14 ++++++++++++--
 jpeg/jpeg.h             |    2 +-
 lib/pluginlib_actions.c |    9 +++++++--
 logo.c                  |    7 +++++++
 mandelbrot.c            |    2 +-
 matrix.c                |    2 +-
 midi/midiplay.c         |   11 +++++++++--
 minesweeper.c           |    2 +-
 mosaique.c              |    8 ++++++--
 oscilloscope.c          |    2 +-
 pacbox/pacbox.h         |    2 +-
 pegbox.c                |    6 ++----
 plasma.c                |    8 ++++++--
 pong.c                  |   11 +++++++++--
 reversi/reversi-gui.h   |   12 ++++++++++--
 robotfindskitten.c      |    2 +-
 rockblox.c              |    6 +++---
 rockblox1d.c            |    7 +++++--
 rockboy/rockboy.c       |    2 +-
 rockpaint.c             |    5 +----
 sliding_puzzle.c        |    4 +---
 snake.c                 |   11 +++++++++--
 snake2.c                |    2 +-
 snow.c                  |    2 +-
 sokoban.c               |    2 +-
 solitaire.c             |    2 +-
 spacerocks.c            |    4 ++--
 star.c                  |   20 +++++++++++++++++---
 starfield.c             |   11 +++++++++--
 stats.c                 |    4 +---
 stopwatch.c             |    2 +-
 sudoku/sudoku.h         |   16 ++++++++--------
 superdom.c              |   11 +++++++++--
 viewer.c                |    2 +-
 vu_meter.c              |    6 ++----
 wormlet.c               |   17 ++++++++++++++---
 xobox.c                 |   13 ++++++++++---
 zxbox/keymaps.h         |   11 +++++++++--
 54 files changed, 292 insertions(+), 115 deletions(-)

Comment by Johannes Schwarz (Ubuntuxer) - Thursday, 02 April 2009, 23:51 GMT+2
I changed the menu button, so you have to press long. (BUTTON_REPEAT)
   fuze_button.patch (46.4 KiB) 
 battery_bench.c         |    9 +++++++--
 blackjack.c             |    2 +-
 bounce.c                |   11 +++++++++--
 brickmania.c            |   16 ++++++++++++++--
 calculator.c            |   31 ++++++++++++++++++++++---------
 calendar.c              |   13 +++++++++++--
 chessbox/chessbox_pgn.h |    2 +-
 chessclock.c            |   13 +++++++++++--
 chopper.c               |    8 ++++++--
 cube.c                  |   13 +++++++++++--
 dict.c                  |    3 +--
 doom/i_video.c          |    8 ++++----
 fireworks.c             |    2 +-
 flipit.c                |    2 +-
 goban/goban.h           |    4 ++--
 invadrox.c              |   10 ++++++++--
 jewels.c                |   14 ++++++++++++--
 jpeg/jpeg.h             |    2 +-
 lib/pluginlib_actions.c |    9 +++++++--
 logo.c                  |    7 +++++++
 mandelbrot.c            |    2 +-
 matrix.c                |    2 +-
 midi/midiplay.c         |   11 +++++++++--
 minesweeper.c           |    2 +-
 mosaique.c              |    8 ++++++--
 oscilloscope.c          |    2 +-
 pacbox/pacbox.h         |    2 +-
 pegbox.c                |    6 ++----
 plasma.c                |    8 ++++++--
 pong.c                  |   11 +++++++++--
 reversi/reversi-gui.h   |   12 ++++++++++--
 robotfindskitten.c      |    2 +-
 rockblox.c              |    6 +++---
 rockblox1d.c            |    7 +++++--
 rockboy/rockboy.c       |    4 ++--
 rockpaint.c             |    5 +----
 sliding_puzzle.c        |    4 +---
 snake.c                 |   11 +++++++++--
 snake2.c                |    2 +-
 snow.c                  |    2 +-
 sokoban.c               |    2 +-
 solitaire.c             |    2 +-
 spacerocks.c            |    4 ++--
 star.c                  |   20 +++++++++++++++++---
 starfield.c             |   11 +++++++++--
 stats.c                 |    4 +---
 stopwatch.c             |    2 +-
 sudoku/sudoku.h         |   16 ++++++++--------
 superdom.c              |   11 +++++++++--
 viewer.c                |    2 +-
 vu_meter.c              |    6 ++----
 wormlet.c               |   17 ++++++++++++++---
 xobox.c                 |   13 ++++++++++---
 zxbox/keymaps.h         |   11 +++++++++--
 54 files changed, 293 insertions(+), 116 deletions(-)

Loading...