Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10075 - FUZE: QUIT Plugin by selecting BUTTON_HOME

Attached to Project: Rockbox
Opened by Johannes Schwarz (Ubuntuxer) - Monday, 30 March 2009, 20:42 GMT+1
Last edited by Thomas Martitz (kugel.) - Friday, 10 April 2009, 19:29 GMT+1
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

It makes more sense to use BUTTON_HOME instead of the current BUTTON_POWER to quit a plugin, because BUTTON_POWER is alongside the player. In the orginal firmware the button is also just scheduled for switch off.

In the following week I'll write a patch for the plugins.
This task depends upon

Closed by  Thomas Martitz (kugel.)
Friday, 10 April 2009, 19:29 GMT+1
Reason for closing:  Accepted
Additional comments about closing:  Committed in r20680. Thank you!
Comment by Johannes Schwarz (Ubuntuxer) - Tuesday, 31 March 2009, 14:53 GMT+1
I have written a patch, which changes the button in addition to the fuze also in the clip, because there's the same button. I haven't change the buttons in spacerocks, solitaire and blackjack, because the BUTTON_HOME is used for something else there. The problem is that this games doesn't have a menu, so key sequence of buttons are used to restart for example a game. This isn't very user friendly. It would be much better to have menu for this plugins. I think it wouldn't be much effort.
   fuze_clip_button.patch (62.5 KiB) 
 changed_rockbox/apps/plugins/battery_bench.c         |   11 -
 changed_rockbox/apps/plugins/beatbox/beatbox.c       |    8 
 changed_rockbox/apps/plugins/blackjack.c             |    7 
 changed_rockbox/apps/plugins/bounce.c                |  165 -------------------
 changed_rockbox/apps/plugins/brickmania.c            |   51 ++---
 changed_rockbox/apps/plugins/calculator.c            |   32 ++-
 changed_rockbox/apps/plugins/calendar.c              |   24 ++
 changed_rockbox/apps/plugins/chessclock.c            |   15 +
 changed_rockbox/apps/plugins/chopper.c               |   10 -
 changed_rockbox/apps/plugins/cube.c                  |   22 ++
 changed_rockbox/apps/plugins/dict.c                  |    7 
 changed_rockbox/apps/plugins/fireworks.c             |    5 
 changed_rockbox/apps/plugins/flipit.c                |   13 -
 changed_rockbox/apps/plugins/goban/goban.h           |    8 
 changed_rockbox/apps/plugins/invadrox.c              |   10 -
 changed_rockbox/apps/plugins/jewels.c                |   22 ++
 changed_rockbox/apps/plugins/jpeg/jpeg.h             |    5 
 changed_rockbox/apps/plugins/lamp.c                  |    3 
 changed_rockbox/apps/plugins/lib/pluginlib_actions.c |   11 -
 changed_rockbox/apps/plugins/logo.c                  |   12 +
 changed_rockbox/apps/plugins/mandelbrot.c            |    6 
 changed_rockbox/apps/plugins/matrix.c                |    8 
 changed_rockbox/apps/plugins/minesweeper.c           |   20 +-
 changed_rockbox/apps/plugins/mosaique.c              |   10 -
 changed_rockbox/apps/plugins/oscilloscope.c          |   12 -
 changed_rockbox/apps/plugins/pacbox/pacbox.h         |    2 
 changed_rockbox/apps/plugins/pegbox.c                |   14 -
 changed_rockbox/apps/plugins/plasma.c                |   10 -
 changed_rockbox/apps/plugins/pong.c                  |   13 +
 changed_rockbox/apps/plugins/reversi/reversi-gui.h   |   14 +
 changed_rockbox/apps/plugins/robotfindskitten.c      |    5 
 changed_rockbox/apps/plugins/rockblox1d.c            |    9 -
 changed_rockbox/apps/plugins/rockblox.c              |    8 
 changed_rockbox/apps/plugins/rockboy/rockboy.c       |    4 
 changed_rockbox/apps/plugins/rockpaint.c             |    8 
 changed_rockbox/apps/plugins/sliding_puzzle.c        |   16 -
 changed_rockbox/apps/plugins/snake2.c                |   19 +-
 changed_rockbox/apps/plugins/snake.c                 |   13 +
 changed_rockbox/apps/plugins/snow.c                  |    6 
 changed_rockbox/apps/plugins/sokoban.c               |   21 --
 changed_rockbox/apps/plugins/star.c                  |   18 +-
 changed_rockbox/apps/plugins/starfield.c             |   13 +
 changed_rockbox/apps/plugins/stats.c                 |    8 
 changed_rockbox/apps/plugins/stopwatch.c             |    9 -
 changed_rockbox/apps/plugins/superdom.c              |   18 +-
 changed_rockbox/apps/plugins/viewer.c                |    8 
 changed_rockbox/apps/plugins/wormlet.c               |    6 
 changed_rockbox/apps/plugins/xobox.c                 |    5 
 changed_rockbox/apps/plugins/zxbox/zxbox_keyb.c      |   14 +
 49 files changed, 391 insertions(+), 367 deletions(-)

Comment by Rafaël Carré (funman) - Wednesday, 01 April 2009, 13:25 GMT+1
tested on clip : the behaviour is not consistent with the menu (power still exits the menu)
Comment by Johannes Schwarz (Ubuntuxer) - Thursday, 02 April 2009, 23:02 GMT+1
I have reworked the patch and deleted the changes on the buttons from the clip. I have tested it elaborately, so it should work well, now.
   fuze_button.patch (45.6 KiB) 
 fuze_button_rockbox/apps/plugins/battery_bench.c         |    9 +++-
 fuze_button_rockbox/apps/plugins/blackjack.c             |    2 
 fuze_button_rockbox/apps/plugins/bounce.c                |   11 ++++-
 fuze_button_rockbox/apps/plugins/brickmania.c            |   16 ++++++-
 fuze_button_rockbox/apps/plugins/calculator.c            |   31 ++++++++++-----
 fuze_button_rockbox/apps/plugins/calendar.c              |   13 +++++-
 fuze_button_rockbox/apps/plugins/chessbox/chessbox_pgn.h |    2 
 fuze_button_rockbox/apps/plugins/chessclock.c            |   13 +++++-
 fuze_button_rockbox/apps/plugins/chopper.c               |    8 ++-
 fuze_button_rockbox/apps/plugins/cube.c                  |   13 +++++-
 fuze_button_rockbox/apps/plugins/dict.c                  |    3 -
 fuze_button_rockbox/apps/plugins/doom/i_video.c          |    8 +--
 fuze_button_rockbox/apps/plugins/fireworks.c             |    2 
 fuze_button_rockbox/apps/plugins/flipit.c                |    2 
 fuze_button_rockbox/apps/plugins/goban/goban.h           |    4 -
 fuze_button_rockbox/apps/plugins/invadrox.c              |   10 +++-
 fuze_button_rockbox/apps/plugins/jewels.c                |   14 +++++-
 fuze_button_rockbox/apps/plugins/jpeg/jpeg.h             |    2 
 fuze_button_rockbox/apps/plugins/lib/pluginlib_actions.c |    9 +++-
 fuze_button_rockbox/apps/plugins/logo.c                  |    7 +++
 fuze_button_rockbox/apps/plugins/mandelbrot.c            |    2 
 fuze_button_rockbox/apps/plugins/matrix.c                |    2 
 fuze_button_rockbox/apps/plugins/midi/midiplay.c         |   11 ++++-
 fuze_button_rockbox/apps/plugins/minesweeper.c           |    2 
 fuze_button_rockbox/apps/plugins/mosaique.c              |    8 ++-
 fuze_button_rockbox/apps/plugins/oscilloscope.c          |    2 
 fuze_button_rockbox/apps/plugins/pacbox/pacbox.h         |    2 
 fuze_button_rockbox/apps/plugins/pegbox.c                |    6 --
 fuze_button_rockbox/apps/plugins/plasma.c                |    8 ++-
 fuze_button_rockbox/apps/plugins/pong.c                  |   11 ++++-
 fuze_button_rockbox/apps/plugins/reversi/reversi-gui.h   |   12 ++++-
 fuze_button_rockbox/apps/plugins/robotfindskitten.c      |    2 
 fuze_button_rockbox/apps/plugins/rockblox1d.c            |    7 ++-
 fuze_button_rockbox/apps/plugins/rockblox.c              |    6 +-
 fuze_button_rockbox/apps/plugins/rockboy/rockboy.c       |    2 
 fuze_button_rockbox/apps/plugins/rockpaint.c             |    5 --
 fuze_button_rockbox/apps/plugins/sliding_puzzle.c        |    4 -
 fuze_button_rockbox/apps/plugins/snake2.c                |    2 
 fuze_button_rockbox/apps/plugins/snake.c                 |   11 ++++-
 fuze_button_rockbox/apps/plugins/snow.c                  |    2 
 fuze_button_rockbox/apps/plugins/sokoban.c               |    2 
 fuze_button_rockbox/apps/plugins/solitaire.c             |    2 
 fuze_button_rockbox/apps/plugins/spacerocks.c            |    4 -
 fuze_button_rockbox/apps/plugins/star.c                  |   20 ++++++++-
 fuze_button_rockbox/apps/plugins/starfield.c             |   11 ++++-
 fuze_button_rockbox/apps/plugins/stats.c                 |    4 -
 fuze_button_rockbox/apps/plugins/stopwatch.c             |    2 
 fuze_button_rockbox/apps/plugins/sudoku/sudoku.h         |   16 +++----
 fuze_button_rockbox/apps/plugins/superdom.c              |   11 ++++-
 fuze_button_rockbox/apps/plugins/viewer.c                |    2 
 fuze_button_rockbox/apps/plugins/vu_meter.c              |    6 --
 fuze_button_rockbox/apps/plugins/wormlet.c               |   17 ++++++--
 fuze_button_rockbox/apps/plugins/xobox.c                 |   13 ++++--
 fuze_button_rockbox/apps/plugins/zxbox/keymaps.h         |   11 ++++-
 54 files changed, 292 insertions(+), 115 deletions(-)

Comment by Johannes Schwarz (Ubuntuxer) - Thursday, 02 April 2009, 23:51 GMT+1
I changed the menu button, so you have to press long. (BUTTON_REPEAT)
   fuze_button.patch (46.4 KiB) 
 fuze_button_rockbox/apps/plugins/battery_bench.c         |    9 +++-
 fuze_button_rockbox/apps/plugins/blackjack.c             |    2 
 fuze_button_rockbox/apps/plugins/bounce.c                |   11 ++++-
 fuze_button_rockbox/apps/plugins/brickmania.c            |   16 ++++++-
 fuze_button_rockbox/apps/plugins/calculator.c            |   31 ++++++++++-----
 fuze_button_rockbox/apps/plugins/calendar.c              |   13 +++++-
 fuze_button_rockbox/apps/plugins/chessbox/chessbox_pgn.h |    2 
 fuze_button_rockbox/apps/plugins/chessclock.c            |   13 +++++-
 fuze_button_rockbox/apps/plugins/chopper.c               |    8 ++-
 fuze_button_rockbox/apps/plugins/cube.c                  |   13 +++++-
 fuze_button_rockbox/apps/plugins/dict.c                  |    3 -
 fuze_button_rockbox/apps/plugins/doom/i_video.c          |    8 +--
 fuze_button_rockbox/apps/plugins/fireworks.c             |    2 
 fuze_button_rockbox/apps/plugins/flipit.c                |    2 
 fuze_button_rockbox/apps/plugins/goban/goban.h           |    4 -
 fuze_button_rockbox/apps/plugins/invadrox.c              |   10 +++-
 fuze_button_rockbox/apps/plugins/jewels.c                |   14 +++++-
 fuze_button_rockbox/apps/plugins/jpeg/jpeg.h             |    2 
 fuze_button_rockbox/apps/plugins/lib/pluginlib_actions.c |    9 +++-
 fuze_button_rockbox/apps/plugins/logo.c                  |    7 +++
 fuze_button_rockbox/apps/plugins/mandelbrot.c            |    2 
 fuze_button_rockbox/apps/plugins/matrix.c                |    2 
 fuze_button_rockbox/apps/plugins/midi/midiplay.c         |   11 ++++-
 fuze_button_rockbox/apps/plugins/minesweeper.c           |    2 
 fuze_button_rockbox/apps/plugins/mosaique.c              |    8 ++-
 fuze_button_rockbox/apps/plugins/oscilloscope.c          |    2 
 fuze_button_rockbox/apps/plugins/pacbox/pacbox.h         |    2 
 fuze_button_rockbox/apps/plugins/pegbox.c                |    6 --
 fuze_button_rockbox/apps/plugins/plasma.c                |    8 ++-
 fuze_button_rockbox/apps/plugins/pong.c                  |   11 ++++-
 fuze_button_rockbox/apps/plugins/reversi/reversi-gui.h   |   12 ++++-
 fuze_button_rockbox/apps/plugins/robotfindskitten.c      |    2 
 fuze_button_rockbox/apps/plugins/rockblox1d.c            |    7 ++-
 fuze_button_rockbox/apps/plugins/rockblox.c              |    6 +-
 fuze_button_rockbox/apps/plugins/rockboy/rockboy.c       |    4 -
 fuze_button_rockbox/apps/plugins/rockpaint.c             |    5 --
 fuze_button_rockbox/apps/plugins/sliding_puzzle.c        |    4 -
 fuze_button_rockbox/apps/plugins/snake2.c                |    2 
 fuze_button_rockbox/apps/plugins/snake.c                 |   11 ++++-
 fuze_button_rockbox/apps/plugins/snow.c                  |    2 
 fuze_button_rockbox/apps/plugins/sokoban.c               |    2 
 fuze_button_rockbox/apps/plugins/solitaire.c             |    2 
 fuze_button_rockbox/apps/plugins/spacerocks.c            |    4 -
 fuze_button_rockbox/apps/plugins/star.c                  |   20 ++++++++-
 fuze_button_rockbox/apps/plugins/starfield.c             |   11 ++++-
 fuze_button_rockbox/apps/plugins/stats.c                 |    4 -
 fuze_button_rockbox/apps/plugins/stopwatch.c             |    2 
 fuze_button_rockbox/apps/plugins/sudoku/sudoku.h         |   16 +++----
 fuze_button_rockbox/apps/plugins/superdom.c              |   11 ++++-
 fuze_button_rockbox/apps/plugins/viewer.c                |    2 
 fuze_button_rockbox/apps/plugins/vu_meter.c              |    6 --
 fuze_button_rockbox/apps/plugins/wormlet.c               |   17 ++++++--
 fuze_button_rockbox/apps/plugins/xobox.c                 |   13 ++++--
 fuze_button_rockbox/apps/plugins/zxbox/keymaps.h         |   11 ++++-
 54 files changed, 293 insertions(+), 116 deletions(-)

Loading...