- Status Closed
- Percent Complete
- Task Type Patches
- Category User Interface
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Version 3.2
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#10093 - Center on loaded file when browsing
This patch centers the browser on the currently loaded font when doing “browse fonts”.
Something smarter should probably be done that does the same for themes, languages and wps files.
Closed by rasher
2009-06-22 18:02
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2009-06-22 18:02
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Committed in r21464
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Updated patch that also works for languages, except when no language is selected, in which case it should use English, but doesn’t currently.
Fixes:
- Now picks English when no language has been set.
- Accidentally set the “current” variable static, which meant it was set even when none of the conditions were true (eg. when browsing themes)
Additions:
- Works for FM presets
- Works for WPS
- Works for RWPS
Remaining bugs:
- set_current_file() does something to the dirbrowser which means you don’t exit it when you press back, so when you browse fonts, and press back, you’re in .rockbox, and back again brings you to the root. Only on the third press on back are you taken to the menu.
Fixes
- Reset dirlevel to 0, so pressing back returns to the menu.
Remaining bugs:
- None!
Commit candidate:
Fixes:
- Remove the DEBUGF
Additions
- Change “Browse Fonts” into “Font” - Change “Browse .wps files” into “While Playing Screen” - Change “Browse .rwps files” into “Remote While Playing Screen” - Change “Browse Themes” into “Browse Theme Files”
Second commit candidate, I’ll probably commit it shortly.
Additions
- Update the manual according to the menu wording changes.