Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10118 - Sansa Fuze : lcd_blit_yuv() (mpegplayer)

Attached to Project: Rockbox
Opened by Rafaël Carré (funman) - Friday, 10 April 2009, 19:47 GMT+2
Last edited by Rafaël Carré (funman) - Tuesday, 12 May 2009, 15:24 GMT+2
Task Type Patches
Category Battery/Charging
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

I think it could be reused as-is for e200v2 as well.

Playback skips some frames, a bit less without audio (probably because of the speed problem noticed with codecs as well)
   0001-Sansa-Fuze-lcd_blit_yuv-adapted-from-c200-ro... (33.7 KiB) 
 b/apps/plugin.c                                       |    2 
 b/apps/plugin.h                                       |    2 
 b/apps/plugins/mpegplayer/mpeg_settings.c             |    2 
 b/apps/plugins/mpegplayer/mpeg_settings.h             |    3 
 b/firmware/SOURCES                                    |    1 
 b/firmware/target/arm/as3525/sansa-fuze/lcd-as-fuze.S |  501 ++++++++++++++++++
 b/firmware/target/arm/as3525/sansa-fuze/lcd-fuze.c    |  121 +++-
 7 files changed, 596 insertions(+), 36 deletions(-)

This task depends upon

Closed by  Rafaël Carré (funman)
Tuesday, 12 May 2009, 15:24 GMT+2
Reason for closing:  Accepted
Comment by Andreas Langmann (cyclon1978) - Wednesday, 15 April 2009, 17:23 GMT+2
i failed to adopt the patch for e200v2 ... i used lcd_blit_yuv from your patch and imported all required methods - screen showed something looking similar to a part of my movie ;-)
Comment by Rafaël Carré (funman) - Thursday, 16 April 2009, 18:36 GMT+2
Perhaps you need to change the vertical/horizontal mode? I'm not sure of the logical screen layout on e200v2
Comment by Andreas Langmann (cyclon1978) - Friday, 17 April 2009, 13:55 GMT+2
now i have it running - but the video is rendered from upper left edge of the player and does not fit in - the video should be rotated by 90 degree so it will fit. I tried to use the different settings for R_ENTRY_MODE for that - but i fear i must change something more... can you share some knowledge about the entry-modes please?
Comment by Rafaël Carré (funman) - Friday, 17 April 2009, 17:52 GMT+2
perhaps try to change the windows (lcd_window_*() ) to make lcd_blit_yuv draw columns instead of lines ?

You should look at the differences (if any) between fuze & e200v2 lcd drivers
Comment by Andreas Langmann (cyclon1978) - Friday, 24 April 2009, 18:13 GMT+2
 FS#10165  - Sansa e200 AMS: lcd_blit_yuv() (mpegplayer) is ready, shoud be merged with this one after approval (shares same lcd-as-fuze.S named lcd-as-e200v2.S)
Comment by Rafaël Carré (funman) - Friday, 24 April 2009, 18:20 GMT+2
Yes definitely, it should be named lcd-as-e200v2-fuze.S

Perhaps this should even go with  FS#9933  : Unify Fuze & e200v2 drivers (why did Jack & Thomas gave up on this one ? :( )
Comment by Thomas Martitz (kugel.) - Sunday, 26 April 2009, 13:21 GMT+2
I didn't gave up, but the scrollwheel revealed some additional differences.

Loading...