Rockbox

Tasklist

FS#10122 - Fix wrong format type of logf functions in speex.c

Attached to Project: Rockbox
Opened by Tomer Shalev (tomers) - Saturday, 11 April 2009, 16:38 GMT
Last edited by Tomer Shalev (tomers) - Wednesday, 30 September 2009, 12:57 GMT
Task Type Patches
Category Codecs
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

When compiling Rockbox with logf enabled you get many warnings for bad format type and too many arguments for format.

This patch fixes this.
This task depends upon

Closed by  Tomer Shalev (tomers)
Wednesday, 30 September 2009, 12:57 GMT
Reason for closing:  Accepted
Additional comments about closing:  Committed in r22857
Comment by Tomer Shalev (tomers) - Saturday, 11 April 2009, 16:42 GMT
Added same fixes that was required in apps/codecs/ape.c too.
Comment by Tomer Shalev (tomers) - Wednesday, 03 June 2009, 11:22 GMT
The compiler warnings are in the following link:
http://pastebin.com/f64d0238

$ uname -a
Linux ubuntu904 2.6.28-11-generic #42-Ubuntu SMP Fri Apr 17 01:57:59 UTC 2009 i686 GNU/Linux

$ gcc -v
Using built-in specs.
Target: i486-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 4.3.3-5ubuntu4' --with-bugurl=file:///usr/share/doc/gcc-4.3/README.Bugs --enable-languages=c,c++,fortran,objc,obj-c++ --prefix=/usr --enable-shared --with-system-zlib --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --enable-nls --with-gxx-include-dir=/usr/include/c++/4.3 --program-suffix=-4.3 --enable-clocale=gnu --enable-libstdcxx-debug --enable-objc-gc --enable-mpfr --enable-targets=all --with-tune=generic --enable-checking=release --build=i486-linux-gnu --host=i486-linux-gnu --target=i486-linux-gnu
Thread model: posix
gcc version 4.3.3 (Ubuntu 4.3.3-5ubuntu4)

Can someone please commit this?
Comment by Tomer Shalev (tomers) - Wednesday, 03 June 2009, 11:23 GMT
The correct versions are:
Using arm-elf-gcc 4.0.3 (400)
Using arm-elf-ld 2.16.1

Loading...