Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10128 - Sansa AMS debug cosmetic fix

Attached to Project: Rockbox
Opened by Michael Chicoine (mc2739) - Tuesday, 14 April 2009, 02:10 GMT+2
Last edited by Thomas Martitz (kugel.) - Monday, 20 April 2009, 22:11 GMT+2
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This is a cosmetic fix for the Sansa AMS ports debug screen. DBOP_DIN displays 8 hex characters until the record button is pressed, then it displays only 4 hex characters (first 4 charactersare "0"). Changed the sprintf parameter from %4x to %8x so that the leading zeros are displayed.
   debug-as3525.c.diff (0.5 KiB) 
 firmware/target/arm/as3525/debug-as3525.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This task depends upon

Closed by  Thomas Martitz (kugel.)
Monday, 20 April 2009, 22:11 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Fixed in r20757.
Comment by Thomas Martitz (kugel.) - Tuesday, 14 April 2009, 03:20 GMT+2
It should only display 4 character, since dbop is a short :/
Comment by Michael Chicoine (mc2739) - Tuesday, 14 April 2009, 05:39 GMT+2
Since dbop is a short, then why would it displaying 8 characters? Could there be someplace it is expanded?
Comment by Thomas Martitz (kugel.) - Wednesday, 15 April 2009, 00:33 GMT+2
According to amiconn it's expanded due to the sign bit. Currently dbop_din is a signed short. Since the sign bit changes due to button presses, the sign bit gets added again before the actual short data. The attached patch just changes it to unsigned. Please test and report back.
   unsigned-dbop.diff (3.3 KiB) 
 firmware/target/arm/as3525/sansa-e200v2/button-e200v2.c |   10 +++++-----
 firmware/target/arm/as3525/debug-as3525.c               |    2 +-
 firmware/target/arm/as3525/sansa-fuze/button-fuze.c     |   10 +++++-----
 3 files changed, 11 insertions(+), 11 deletions(-)

Comment by Michael Chicoine (mc2739) - Wednesday, 15 April 2009, 02:11 GMT+2
The patch works on the e200v2, although I had to change button-target.h to get it to build. Attached is the updated patch.
   unsigned-dbop-v2.diff (4.3 KiB) 
 firmware/target/arm/as3525/sansa-e200v2/button-target.h |    2 +-
 firmware/target/arm/as3525/sansa-e200v2/button-e200v2.c |   10 +++++-----
 firmware/target/arm/as3525/debug-as3525.c               |    2 +-
 firmware/target/arm/as3525/sansa-fuze/button-fuze.c     |   10 +++++-----
 firmware/target/arm/as3525/sansa-fuze/button-target.h   |    2 +-
 5 files changed, 13 insertions(+), 13 deletions(-)

Loading...