Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10132 - set font to FONT_UI when exit plugin.

Attached to Project: Rockbox
Opened by Teruaki Kawashima (teru) - Tuesday, 14 April 2009, 11:08 GMT+2
Last edited by Alexander Levin (fml2) - Thursday, 14 May 2009, 23:57 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

this patch makes plugin to set font to FONT_UI when exit them if it set to FONT_SYSFIXED.
what is problem is it affects the font of splash and it results in showing empty box if language is set to japanese, chinese, etc..

it might be easier/simpler to do it in plugin_load in apps/plugin.c after returning from a plugin.
   set_font_ui_before_exit_plugin.patch (15.1 KiB) 
 apps/plugins/sliding_puzzle.c                      |    1 +
 apps/plugins/flipit.c                              |    4 +++-
 apps/plugins/rockblox1d.c                          |    1 +
 apps/plugins/battery_bench.c                       |    9 +++++++++
 apps/plugins/fireworks.c                           |    3 ---
 apps/plugins/snake2.c                              |    2 ++
 apps/plugins/midi/midiplay.c                       |    3 ++-
 apps/plugins/star.c                                |    1 +
 apps/plugins/calendar.c                            |    2 ++
 apps/plugins/doom/rockdoom.c                       |    6 ++++--
 apps/plugins/greyscale.c                           |    1 +
 apps/plugins/cube.c                                |    5 ++++-
 apps/plugins/test_boost.c                          |    1 +
 apps/plugins/vu_meter.c                            |    9 +++++++--
 apps/plugins/rockboy/menu.c                        |    2 +-
 apps/plugins/rockboy/rockboy.c                     |    6 ++++--
 apps/plugins/sokoban.c                             |   13 ++++++++-----
 apps/plugins/beatbox/beatbox.c                     |    3 ++-
 apps/plugins/calculator.c                          |    4 ++++
 apps/plugins/wormlet.c                             |    1 +
 firmware/target/arm/tcc780x/debug-tcc780x.c        |    1 +
 firmware/target/arm/tcc77x/debug-tcc77x.c          |    1 +
 firmware/target/arm/tms320dm320/debug-dm320.c      |    1 +
 firmware/target/arm/imx31/debug-imx31.c            |    4 +++-
 firmware/target/arm/s3c2440/debug-s3c2440.c        |    4 +++-
 firmware/target/mips/ingenic_jz47xx/debug-jz4740.c |    1 +
 26 files changed, 68 insertions(+), 21 deletions(-)

This task depends upon

Closed by  Alexander Levin (fml2)
Thursday, 14 May 2009, 23:57 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed with r20930. Thanks!
Comment by Teruaki Kawashima (teru) - Friday, 17 April 2009, 16:26 GMT+2
this is patch to set font to FONT_UI after returning from plugin.
   set_font_ui_after_exit_plugin.patch (0.3 KiB) 
 apps/plugin.c |    1 +
 1 file changed, 1 insertion(+)

Comment by Alexander Levin (fml2) - Monday, 27 April 2009, 22:27 GMT+2
I would like to commit the second patch. Any objections/concerns?

Loading...