Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10136 - Touchscreen mode switching in plugins

Attached to Project: Rockbox
Opened by Maurus Cuelenaere (mcuelenaere) - Wednesday, 15 April 2009, 19:07 GMT+2
Last edited by Maurus Cuelenaere (mcuelenaere) - Sunday, 19 April 2009, 17:22 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

When entering some plugins on a touchscreen target, the touchscreen mode sometimes gets set to 3x3 grid when leaving the plugin even though the original setting was absolute mode.

This patch sets the touchscreen mode to 3x3 grid for rockpaint and sets the old mode back when leaving (ideally this should be done for all plugins - or they should get adapted to absolute point mode).
   touchscreen_mode_rockpaint.diff (1.3 KiB) 
 apps/plugins/rockpaint.c |   10 ++++++++++
 apps/plugin.c            |    4 ++++
 apps/plugin.h            |    4 ++++
 3 files changed, 18 insertions(+)

This task depends upon

Closed by  Maurus Cuelenaere (mcuelenaere)
Sunday, 19 April 2009, 17:22 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Committed plugin touchscreen mode switching in r20738
Comment by Rob Purchase (shotofadds) - Saturday, 18 April 2009, 01:02 GMT+2
Wouldn't it be easier for the plugin loader to do this? ie. enable grid mode before entering the plugin, and return to the user's preference afterwards.

Those small minority of plugins that are adapted to touchscreen usage should set absolute mode themselves, imho.
Comment by Jonathan Gordon (jdgordon) - Saturday, 18 April 2009, 01:15 GMT+2
agreed...
edit: to elaborate.. the reason 3x3 was added was to make plugins easy to get working... so yes they shuold default to being grid and the ones which are converted should manually swicth to touch
Comment by Maurus Cuelenaere (mcuelenaere) - Saturday, 18 April 2009, 14:28 GMT+2
Hmm I agree, but IMO this is a hack and should get removed in the future.. (will work on a patch for this)

edit:
How is the user going to know in which mode it is? Shouldn't there be a visual confirmation when switching modes?

Loading...