Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Drivers
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by tomers - 2009-04-25
Last edited by fg - 2009-05-23

FS#10166 - USB arrangement - use constants and some cosmetics

This patch contains the following:

1. Use some constants to make code clearer.
2. Some cosmetics
3. Remove redundant definitions of various places which are similar to those in ch9.h and other headers.
4. Add some verbosity (logf) in usb-drv-arc.c

   usb_arrangement.diff (26.3 KiB)
Closed by  fg
2009-05-23 15:10
Reason for closing:  Out of Date
Admin
fg commented on 2009-04-25 18:31

Some comments:
- usb_drv_request_endpoint() gets a new type parameter which isn’t used anywhere else. Included here by accident?
- you remove EPCTRL_EP_TYPE_ISO and friends in usb-drv-arc.c without adding them elsewhere or updating the places that use them
- usb.c contains non-style things (the usb_core_enable_driver(USB_DRIVER_HID, false) lines). Are they supposed to be included here? (I don’t object to them, I just think they belong in a different commit)

In general though, are all the indentation and whitespace changes really needed? In some places, you actually change the indentation style (e.g. usb.c), something that docs/CONTRIBUTING specifically asks not to do.

tomers commented on 2009-04-26 22:21

Fixed patch.
- Removed changes that belong to future patches.
- EPCTRL_EP_TYPE_XXX no replaced with USB_ENDPOINT_XFER_XXX which is defined in usb_ch9.h
- Removed most cosmetics changes.

   usb_arrangement.diff (26.3 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing