This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#10166 - USB arrangement - use constants and some cosmetics
Attached to Project:
Rockbox
Opened by Tomer Shalev (tomers) - Saturday, 25 April 2009, 19:05 GMT+2
Last edited by Frank Gevaerts (fg) - Saturday, 23 May 2009, 17:10 GMT+2
Opened by Tomer Shalev (tomers) - Saturday, 25 April 2009, 19:05 GMT+2
Last edited by Frank Gevaerts (fg) - Saturday, 23 May 2009, 17:10 GMT+2
|
DetailsThis patch contains the following:
1. Use some constants to make code clearer. 2. Some cosmetics 3. Remove redundant definitions of various places which are similar to those in ch9.h and other headers. 4. Add some verbosity (logf) in usb-drv-arc.c 
usb_arrangement.diff
(26.3 KiB)
firmware/export/usb_core.h | 11 +++ firmware/export/usb.h | 2 firmware/usb.c | 11 ++- firmware/usbstack/usb_core.c | 29 +++----- firmware/target/arm/usb-drv-arc.c | 124 +++++++++++++++++----------------- firmware/drivers/isp1583.c | 136 +++++++++++++++++++------------------- firmware/ifp_usb_serial.c | 3 7 files changed, 166 insertions(+), 150 deletions(-) |
This task depends upon
- usb_drv_request_endpoint() gets a new type parameter which isn't used anywhere else. Included here by accident?
- you remove EPCTRL_EP_TYPE_ISO and friends in usb-drv-arc.c without adding them elsewhere or updating the places that use them
- usb.c contains non-style things (the usb_core_enable_driver(USB_DRIVER_HID, false) lines). Are they supposed to be included here? (I don't object to them, I just think they belong in a different commit)
In general though, are all the indentation and whitespace changes really needed? In some places, you actually change the indentation style (e.g. usb.c), something that docs/CONTRIBUTING specifically asks not to do.
- Removed changes that belong to future patches.
- EPCTRL_EP_TYPE_XXX no replaced with USB_ENDPOINT_XFER_XXX which is defined in usb_ch9.h
- Removed most cosmetics changes.