Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10194 - Remove usage of pluginlib actions from bubbles plugin

Attached to Project: Rockbox
Opened by William Poetra Yoga Hadisoeseno (wpyh) - Saturday, 09 May 2009, 17:19 GMT+2
Last edited by Thomas Martitz (kugel.) - Monday, 21 November 2011, 12:53 GMT+2
Task Type Patches
Category Games
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

According to an earlier discussion on IRC (a long time ago), pluginlib actions are not desirable and should be removed. This patch removes pluginlib actions from the bubbles plugin.

What this patch does:
1. Remove pluginlib actions and replace them with button codes.
2. Remove #define's made unneccessary by r19253.
3. Some minor cleanups here and there.
   bubbles.v1.diff (9.3 KiB) 
 apps/plugins/bubbles.c |  197 +++++++++++++++++++++++++++++++++++++------------
 1 file changed, 151 insertions(+), 46 deletions(-)

This task depends upon

Closed by  Thomas Martitz (kugel.)
Monday, 21 November 2011, 12:53 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  The pluginlib actions are useful. Please show me the discussion.
Comment by William Poetra Yoga Hadisoeseno (wpyh) - Sunday, 10 May 2009, 05:06 GMT+2
Btw, I've tested this patch on iPod 5.5G and Sansa Fuze, without problems so far.
Comment by Johannes Schwarz (Ubuntuxer) - Thursday, 21 May 2009, 21:46 GMT+2
The patch works fine for me. What is the principal reason to remove pluginlib?

Loading...