Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10208 - Improved Ogg Vorbis comment reader.

Attached to Project: Rockbox
Opened by Magnus Holmgren (learman) - Wednesday, 13 May 2009, 21:07 GMT+2
Last edited by Magnus Holmgren (learman) - Sunday, 31 May 2009, 15:51 GMT+2
Task Type Patches
Category ID3 / meta data
Status Closed
Assigned To Magnus Holmgren (learman)
Player Type SW-codec
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch improves the Vorbis comment reader, to support tags that occupies more than one Ogg page. It works fine on a couple of test tracks I have (Ogg Vorbis, Speex, FLAC), but I'd appreciate if someone with more files could test it a bit too (particularly files where the metadata isn't read properly, if possible).
This task depends upon

Closed by  Magnus Holmgren (learman)
Sunday, 31 May 2009, 15:51 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  A slightly modified version was committed in r21134.
Comment by Magnus Holmgren (learman) - Wednesday, 13 May 2009, 21:08 GMT+2
Annoying; forget to fill in a field, and Flyspray forgets the attachment...
   vorbis_comments.patch (12.4 KiB) 
 apps/metadata/vorbis.c          |  321 +++++++++++++++++++++++++++++++++++-----
 apps/metadata/flac.c            |    2 
 apps/metadata/ogg.c             |   59 -------
 apps/metadata/metadata_common.h |    2 
 4 files changed, 286 insertions(+), 98 deletions(-)

Loading...