Rockbox

Tasklist

FS#10221 - RBUtil doesn't install bootloader file at all

Attached to Project: Rockbox
Opened by Clément Pit--Claudel (CFP) - Tuesday, 19 May 2009, 17:44 GMT
Last edited by Dominik Wenger (Domonoky) - Saturday, 20 June 2009, 16:34 GMT
Task Type Patches
Category Rbutil
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Verified with a fresh checkout of the source. When installing the bootloader (bootloaderinstallfile.cpp), the file is not copied to the target. Eg. w/ Gigabeat : the file FWIMG01.dat is renamed, but no new file is copied. And of course, the device won't boot.
This is due to line being inverted in bootloaderinstallfile.cpp : the file is closed before being moved.
Attached a patch against 20987 to fix this bug.
This task depends upon

Closed by  Dominik Wenger (Domonoky)
Saturday, 20 June 2009, 16:34 GMT
Reason for closing:  Fixed
Additional comments about closing:  Should be fixed with 1.2.2, if not, please reopen.
Comment by Clément Pit--Claudel (CFP) - Tuesday, 19 May 2009, 17:45 GMT
Woops, added the whole file...
Comment by Clément Pit--Claudel (CFP) - Wednesday, 20 May 2009, 05:23 GMT
Woops, posted this in bugs while it should have gone into patches...
Comment by Dominik Riebeling (bluebrother) - Wednesday, 20 May 2009, 06:54 GMT
Are you sure this is the actual issue? From the documentation of QFile::rename() which is inherited by QTemporaryFile (http://doc.qtsoftware.com/4.5/qfile.html#rename):

The file is closed before it is renamed.

Thus from my understanding this change won't make a difference here. What I'd like to see improved (might give it a go later today) is better error reporting: if the rename failed the user should get displayed an error instead of the current silent failure.

The original issue has also been reported here: http://forums.rockbox.org/index.php?topic=21614.0
Comment by Clément Pit--Claudel (CFP) - Wednesday, 20 May 2009, 16:41 GMT
You're right.
Actually, it seems that everything works fine when building RBUtil from a fresh source.
Clément.
Comment by Dominik Wenger (Domonoky) - Friday, 22 May 2009, 17:46 GMT
This really points looks like another bug in the newest Qt release (4.5.1).
We should really make a new build with a older Qt version for windows.
Comment by Dominik Riebeling (bluebrother) - Friday, 22 May 2009, 20:00 GMT
Clement: which version did you build? I.e. Windows, Linux, OS X? Which version of Qt did you use for building?
Comment by Justin Hannigan (Chronon) - Saturday, 23 May 2009, 06:28 GMT
I had the same issue with Olympus MR-100 when installing the Rockbox bootloader with the Windows version of Rockbox Utility. I can try the Linux version in a few days if it's helpful. The original firmware is moved to "/system/OF.mi4" but the Rockbox bootloader is not copied to "/system/PP5020.mi4" This was with version 1.2.1 downloaded from the wiki page.

Comment by Clément Pit--Claudel (CFP) - Saturday, 23 May 2009, 11:56 GMT
Dominik: Built from svn checkout, with last Qt version (downloaded from the official website) under Linux.

Loading...