Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10226 - isp1583.c code cosmetics

Attached to Project: Rockbox
Opened by Tomer Shalev (tomers) - Friday, 22 May 2009, 06:30 GMT+2
Last edited by Tomer Shalev (tomers) - Thursday, 01 October 2009, 07:41 GMT+2
Task Type Patches
Category Battery/Charging
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

- Code cosmetics
- Use defined EP_CONTROL instead of 0 when applicable.
   isp1583_cosmetics.diff (11.8 KiB) 
 firmware/drivers/isp1583.c |  156 +++++++++++++++++++++++----------------------
 1 file changed, 83 insertions(+), 73 deletions(-)

This task depends upon

Closed by  Tomer Shalev (tomers)
Thursday, 01 October 2009, 07:41 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r22866, including mcuelenaere's suggestions
Comment by Maurus Cuelenaere (mcuelenaere) - Friday, 22 May 2009, 15:11 GMT+2
Hmm I like most of the whitespace changes, but I don't like placing braces around single lines in if() structures.
Also I dislike your changes in the alignment when several parameters don't fit in one line (e.g. first part of @@ -195,15 +195,17 @@).

And AFAIK the Rockbox contribution rules prescribe: 'When changing code, follow the code style of the file you are editing.'

Loading...