This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#10244 - Pure Data for Rockbox plugin - patch round 2
Attached to Project:
Rockbox
Opened by Wincent Balin (wincent) - Monday, 25 May 2009, 23:20 GMT+2
Last edited by Peter D'Hoye (petur) - Saturday, 04 July 2009, 00:18 GMT+2
Opened by Wincent Balin (wincent) - Monday, 25 May 2009, 23:20 GMT+2
Last edited by Peter D'Hoye (petur) - Saturday, 04 July 2009, 00:18 GMT+2
|
DetailsPatch pdbox-3-dbestfit-rockboxed.diff: dbestfit got rockboxed. printf-s were excluded using #ifdef DEBUG and #ifndef ROCKBOX if appropriate. Some additions to the signedness of variables were made. Most of changes were responses to the compiler warnings when compiling for the H300 DAP.
Patch pdbox-3-dbestfit-integrated.diff: Integration of dbestfit library both into the building process and into the pdbox plug-in. 
pdbox-3-dbestfit-rockboxed.diff
(4.1 KiB)
apps/plugins/pdbox/dbestfit-3.3/bysize.c | 4 ++++ apps/plugins/pdbox/dbestfit-3.3/bmalloc.c | 2 ++ apps/plugins/pdbox/dbestfit-3.3/dmalloc.c | 24 ++++++++++++++++++++++-- apps/plugins/pdbox/dbestfit-3.3/bmalloc.h | 2 +- apps/plugins/pdbox/dbestfit-3.3/dmalloc.h | 5 +++++ 5 files changed, 34 insertions(+), 3 deletions(-)
pdbox-3-dbestfit-integrated.diff
(1.4 KiB)
apps/plugins/pdbox/pdbox.c | 4 +--- apps/plugins/pdbox/pdbox.h | 2 -- apps/plugins/pdbox/SOURCES | 2 -- 3 files changed, 1 insertion(+), 7 deletions(-) |
This task depends upon
Included this file into the SOURCES file.
- Is it correct that the functions in this patch do nothing on target ?
- In the target case, you do things like : "fmt=fmt;" is this to supress warnings ? if so, better use "(void)fmt;"
Functions postatom and postfloat are still fully present on target.
I replaced the "fmt=fmt". Shall I post the new diff?
IF YOU APPLIED THE PREVIOUS ONE -- REVERSE IT!
(I hope capital letters are appropriate here.)
The same patch, where 1,$ s/fmt\ =\ fmt/(void)\ fmt/g was applied.
I changed them, and commited it.
If it does not achieve it's aim, I won't do that again.
A first look shows the really really big cosinus table. Is this really needed ? Maybe you could use a smaller table and interpolate inbetween.
Also cos_table.h misses the protection against multiple inclusions, and cos_table.c seems to include the wrong header.
And filters.h includes <math.h> Is this available in Rockbox ?
The rest of the changes look fine, from my first look at it.
About splitting changes into different patches:
This time it would have been good to make one with only the changes to suppress compiler warning, and another with the real changes needed.
As for math.h , it gets included for constant values (like M_PI) only; while rockbox does not include libm, the compiler includes it's built-ins when working with floating-point values.
As for splitting changes, I am afraid that I am far ahead again, so for the next patch I will have to split it between suppressions for compiler warnings, floating point additions and sound additions. I hope they are separatable, because many changes might be made in the same file. Do you know by chance a tool that might help here?
The attached file contains additional functions Rockbox does not have yet.
without all the previous ones that were posted here!
Current status: a pd file gets loaded and a structure gets created from the contents
of the file (or many files, if another file has to be loaded into the first one).
Furthermore, the system begins to generate data. There is no sound output yet.
Warning: The patch still has debugging printfs!
Warning2: If you compiled pdbox before, remove it's object files (with "make clean" or explicitely)
to recompile with new sources (something wrong in the pdbox.make file).
- remove the #defines that wrap the rb-> calls, and use apps/plugins/lib/wrappers.h
I also fixed some svn keyword issues and wrong line-endings. Please check that too next time you make a patch.