Rockbox

Tasklist

FS#10251 - plugin keymaps for Samsung YH-820 YH-920 YH-925

Attached to Project: Rockbox
Opened by Jens Erdmann (pyro_maniac) - Wednesday, 27 May 2009, 20:21 GMT
Task Type Patches
Category Plugins
Status Unconfirmed
Assigned To No-one
Operating System Another
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

- First try of making plugin keymaps for Samsung YH-820 YH-920 YH-925
This task depends upon

Comment by Jens Erdmann (pyro_maniac) - Wednesday, 27 May 2009, 20:21 GMT
Sry, there was an error on attching.
Comment by Rafaël Carré (funman) - Wednesday, 27 May 2009, 20:27 GMT
thanks for looking at this

"+#elif CONFIG_KEYPAD == SAMSUNG_YH_PA" shouldn't it be SAMSUNG_YH_PAD ?

Comment by Thomas Martitz (kugel.) - Wednesday, 27 May 2009, 20:45 GMT
Using the REC button should be discouraged, as it is actually a switch on 92x (like the hold switch) IMO.
Comment by Rafaël Carré (funman) - Wednesday, 27 May 2009, 20:56 GMT
some plugins make it easy to use switches.

example in rockblox:

#elif CONFIG_KEYPAD == PLAYER_PAD

#define ROCKBLOX_OFF_PRE BUTTON_STOP
#define ROCKBLOX_OFF (BUTTON_STOP|BUTTON_REL)

Comment by Jens Erdmann (pyro_maniac) - Thursday, 28 May 2009, 08:12 GMT
Oh sorry, SAMSUNG_YH_PA is a copy and past misstake. i will rework that later.

And the REC button was only the first idea to have some.
Comment by Thomas Martitz (kugel.) - Thursday, 28 May 2009, 09:06 GMT
I think we should commit early (as soon as all plugins build and have a keymap). We can fix bad keymaps later on a per-plugin basis.
Comment by Rafaël Carré (funman) - Thursday, 28 May 2009, 11:01 GMT
I suggest we maintain a list of tested plugins here before committing, so we can be several people to test to go quicker.

This can be done before or after committing.
Comment by Jens Erdmann (pyro_maniac) - Thursday, 28 May 2009, 19:48 GMT
- fix typo "SAMSUNG_YH_PA"
Comment by Rafaël Carré (funman) - Thursday, 04 June 2009, 17:02 GMT
You should also modify apps/plugins/lib/pluginlib_actions.c : some plugins use this list and don't have a list of per-target keymaps

EDIT: you also need to enable plugins in tools/configure

by the way the rec switch to exit plugins (tested cube) is not very user friendly :)
Comment by Jens Erdmann (pyro_maniac) - Thursday, 04 June 2009, 19:24 GMT
i edited tools/configure and apps/plugins/lib/pluginlib_actions.c. I don't have an idea for the rec switch right now.
Comment by Jens Erdmann (pyro_maniac) - Wednesday, 17 June 2009, 15:54 GMT
The last patch wasn't tested enough. Sorry for that. This one should completly compile and work.

- fix remaining errors
- add missing defines
Comment by MichaelGiacomelli (saratoga) - Tuesday, 04 August 2009, 00:17 GMT
Heres an updated version. I think all thats missing is pacbox and the menu button for rockboy (couldn't see how to do this without owning the unit).

If someone fixes this I'll commit.
Comment by MichaelGiacomelli (saratoga) - Tuesday, 04 August 2009, 03:33 GMT
I've committed this patch, although keymaps are still a little rough and karl informs me that I've broken his recent blackjack clean up, so I'll leave this open. I'd appreciate someone going through these plugins and letting me know if any of the buttons aren't physically workable.

Loading...