Rockbox

Tasklist

FS#10271 - automatically disable voice upon rockdoom startup

Attached to Project: Rockbox
Opened by Christian Beier (dontmind) - Wednesday, 03 June 2009, 13:29 GMT
Last edited by Karl Kurbjun (kkurbjun) - Friday, 18 December 2009, 04:26 GMT
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

hi there,
attached is a simple fix to disable voice upon doom startup and re-enable it upon quitting rockdoom, in the fashion other plugins do it (e.g. mpegplayer).

tested succesfully on my ipod 5.5g.
This task depends upon

Closed by  Karl Kurbjun (kkurbjun)
Friday, 18 December 2009, 04:26 GMT
Reason for closing:  Accepted
Additional comments about closing:  Thanks!
Comment by Rafaël Carré (funman) - Friday, 05 June 2009, 17:50 GMT
if( result == -1 )
+ {
+ rb->talk_disable(false);
return PLUGIN_OK; // Quit was selected
+ }
else
+ {
+ rb->talk_disable(false);
return PLUGIN_ERROR; // Missing base wads
+ }
}

You can just add rb->talk_disable(false); before if( result == -1 )
Comment by Christian Beier (dontmind) - Friday, 05 June 2009, 18:54 GMT
ahm..., right ;-)
Comment by Christian Beier (dontmind) - Wednesday, 17 June 2009, 09:07 GMT
any chance of having this commited?
it's a simple fix for a simple issue...
Comment by Gman (Thecoolgman) - Wednesday, 17 June 2009, 10:15 GMT
I think it should be compiled
Comment by Gman (Thecoolgman) - Wednesday, 17 June 2009, 10:15 GMT
I mean commited :P

Loading...