Rockbox

Tasklist

FS#10314 - Set Rockbox SVN root svn:ignore keyword to ignore build directories

Attached to Project: Rockbox
Opened by Maurus Cuelenaere (mcuelenaere) - Thursday, 11 June 2009, 12:31 GMT
Last edited by Maurus Cuelenaere (mcuelenaere) - Saturday, 13 June 2009, 17:51 GMT
Task Type Patches
Category Build environment
Status Closed
Assigned To No-one
Operating System Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch adds build* and output directories to the svn:ignore property of the Rockbox SVN root folder.
This task depends upon

Closed by  Maurus Cuelenaere (mcuelenaere)
Saturday, 13 June 2009, 17:51 GMT
Reason for closing:  Accepted
Additional comments about closing:  Committed in r21277.
Comment by Rafaël Carré (funman) - Friday, 12 June 2009, 22:13 GMT
if they are used by release scripts then it's useful
Comment by Maurus Cuelenaere (mcuelenaere) - Saturday, 13 June 2009, 13:14 GMT
I think it's useful because I name my build directories build1, build2, build3, etc.. and put them inside the SVN root (and don't want them to show up in svn status); I'm not sure how others handle this so that's why I posted a patch instead of committing it directly to SVN.

> if they are used by release scripts then it's useful

I'm not sure what release scripts you're talking about ? (tools/release/* ?)
If so, they use build-<target_name> as temporary build directories and output as output directory (hence I also added output to svn:ignore).
Comment by Dominik Riebeling (bluebrother) - Saturday, 13 June 2009, 13:24 GMT
I think this is useful, regardless of release scripts. The wiki tells you to create a build folder called "build" and I bet most people will use this or some "build-<something>" naming. The only thing that looks pointless to me is the patch itself -- as far as I know there's no way to make patch apply property changes. Or did I miss something here?
Comment by Rafaël Carré (funman) - Saturday, 13 June 2009, 13:38 GMT
Maurus, yes i meant these scripts (i use out of tree build directories)

Dominik, I understood that the "patch" was there only for comments
Comment by Maurus Cuelenaere (mcuelenaere) - Saturday, 13 June 2009, 17:46 GMT
Dominik: hmm yes, I hadn't thought about the fact that 'patch' doesn't do anything to the svn metadata..

I'll just commit it then as no-one seems to object.

Loading...