Rockbox

Tasklist

FS#10330 - pluginlib: xlcd_scroll_* functions should clear screen for high scroll count

Attached to Project: Rockbox
Opened by Torne Wuff (torne) - Sunday, 14 June 2009, 00:44 GMT
Last edited by Torne Wuff (torne) - Friday, 16 October 2009, 20:18 GMT
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The xlcd_scroll_* functions in pluginlib check if the pixel count to scroll is more than the relevant screen dimension, and if so they do nothing. This seems wrong: if you ask to scroll up by LCD_HEIGHT - 1 then it clears all the lines of the screen except the top, so scrolling by LCD_HEIGHT or more should logically just clear the entire screen.

Attached patch makes them call lcd_clear_display() instead of doing nothing.

The greylib scroll functions have the same bug, but the fix is not so trivial, and I've not delved into how greylib works..
This task depends upon

Closed by  Torne Wuff (torne)
Friday, 16 October 2009, 20:18 GMT
Reason for closing:  Fixed
Additional comments about closing:  Submitted in r23211
Comment by Torne Wuff (torne) - Friday, 16 October 2009, 19:53 GMT
Updated to include greylib, and to include the new xlcd packing mode.

Loading...