Rockbox

Tasklist

FS#10333 - iAudio M3 "SELECT" and "DONE" not working on remote in keyboard context.

Attached to Project: Rockbox
Opened by Richard Corden (RichardC) - Sunday, 14 June 2009, 21:50 GMT
Task Type Patches
Category Remote
Status Unconfirmed
Assigned To No-one
Operating System Another
Severity Low
Priority Normal
Reported Version Version 3.2
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details


When adding text via the keyboard, neither the selection function nor the done function work using the remote play button. Pressing 'play' on the main unit however, does work and has the correct behaviour.

I checked the keymap-m3.c source and I noticed that unlike the other entires, the last entry for these options refers to the main unit buttons and not the remote:

{ ACTION_KBD_SELECT, BUTTON_RC_PLAY|BUTTON_REL, BUTTON_PLAY },
{ ACTION_KBD_DONE, BUTTON_RC_PLAY|BUTTON_REPEAT, BUTTON_PLAY },


I changed the entries to the following:

{ ACTION_KBD_SELECT, BUTTON_RC_PLAY|BUTTON_REL, BUTTON_RC_PLAY },
{ ACTION_KBD_DONE, BUTTON_RC_PLAY|BUTTON_REPEAT, BUTTON_RC_PLAY },


After rebuilding and installing this change onto my M3 the keybord now works when using the remote.

Attached is the patch file for this change.



This task depends upon

Loading...