Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10379 - Fix lua coding style

Attached to Project: Rockbox
Opened by Daurnimator (daurnimator) - Wednesday, 24 June 2009, 17:45 GMT+2
Last edited by Maurus Cuelenaere (mcuelenaere) - Sunday, 28 June 2009, 16:55 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Fixed lua coding style in helloworld and test_viewports:
optimised some code, made it more readable
   patch.diff (12.8 KiB) 
 apps/plugins/test_viewports.lua |  131 ++++++++++++++---------------
 apps/plugins/helloworld.lua     |  175 +++++++++++++++++-----------------------
 2 files changed, 138 insertions(+), 168 deletions(-)

This task depends upon

Closed by  Maurus Cuelenaere (mcuelenaere)
Sunday, 28 June 2009, 16:55 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  In r21541.
Comment by Maurus Cuelenaere (mcuelenaere) - Wednesday, 24 June 2009, 19:52 GMT+2
Most of these changes are whitespace changes, which I'm not inclined to accept; see the Rockbox guidelines for more information: http://svn.rockbox.org/viewvc.cgi/trunk/docs/CONTRIBUTING?view=markup

I will probably commit some of the functional changes when I'll remove the current way to access files and replace it with the Lua IO library, but I'll need your real name for that (again, see the guidelines).
Comment by Daurnimator (daurnimator) - Thursday, 25 June 2009, 18:20 GMT+2
oh well,
You can do what you want, I just thought it was very unreadable.
Comment by Maurus Cuelenaere (mcuelenaere) - Thursday, 25 June 2009, 18:58 GMT+2
Well, I don't agree with you :)

Anyway, I will commit the functional changes; but as I said I need your real name for that.

Loading...