Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10386 - changable wheel scroll speed

Attached to Project: Rockbox
Opened by Sanggon, Lee (isanggon) - Saturday, 27 June 2009, 14:28 GMT+2
Task Type Patches
Category Settings
Status Unconfirmed
Assigned To No-one
Player Type iPod 5G
Severity Low
Priority Normal
Reported Version Version 3.3
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

This patch adds a changable wheel scroll speed option on ipod video.
   fs#_____wheel_speed.diff (5.3 KiB) 
 rockbox-21519/apps/lang/english.lang                       |   14 ++++++++
 rockbox-21519/apps/menus/settings_menu.c                   |    2 +
 rockbox-21519/apps/settings.h                              |    2 +
 rockbox-21519/apps/settings_list.c                         |    3 +
 rockbox-21519/firmware/export/button.h                     |    2 -
 rockbox-21519/firmware/target/arm/ipod/button-clickwheel.c |   21 +++++--------
 6 files changed, 31 insertions(+), 13 deletions(-)

This task depends upon

Comment by Gman (Thecoolgman) - Sunday, 28 June 2009, 00:17 GMT+2
This doesn't even compile.
Comment by Fred Bauer (freddyb) - Wednesday, 07 July 2010, 04:18 GMT+2
I thought this was a good idea so I touched it up to work with current SVN. It shows up under General Settings > System > Thumb Wheel Speed.
   ipod_wheel_speed.diff (5 KiB) 
 apps/lang/english.lang                       |   14 ++++++++++++++
 apps/settings.h                              |    4 ++++
 apps/menus/settings_menu.c                   |    7 +++++++
 apps/settings_list.c                         |    5 +++++
 firmware/export/button.h                     |    4 ++++
 firmware/target/arm/ipod/button-clickwheel.c |   18 ++++++++++++++----
 6 files changed, 48 insertions(+), 4 deletions(-)

Comment by Fred Bauer (freddyb) - Wednesday, 07 July 2010, 16:03 GMT+2
Removed an unnecessary include.
   ipod_wheel_speedv2.diff (4.9 KiB) 
 apps/lang/english.lang                       |   14 ++++++++++++++
 apps/settings.h                              |    4 ++++
 apps/menus/settings_menu.c                   |    7 +++++++
 apps/settings_list.c                         |    5 +++++
 firmware/export/button.h                     |    4 ++++
 firmware/target/arm/ipod/button-clickwheel.c |   17 +++++++++++++----
 6 files changed, 47 insertions(+), 4 deletions(-)

Comment by Fred Bauer (freddyb) - Wednesday, 07 July 2010, 16:41 GMT+2
More fix ups.
   ipod_wheel_speedv3.diff (5.2 KiB) 
 apps/lang/english.lang                       |   14 ++++++++++++++
 apps/settings.h                              |    4 ++++
 apps/menus/settings_menu.c                   |    7 +++++++
 apps/settings_list.c                         |    5 +++++
 firmware/export/button.h                     |    4 ++++
 firmware/target/arm/ipod/button-clickwheel.c |   12 ++++++++----
 6 files changed, 42 insertions(+), 4 deletions(-)

Comment by Rosso Maltese (asettico) - Thursday, 08 July 2010, 15:15 GMT+2
It breaks the boot loader build for ipodvideo 5.5g 64 MB.
HTH
Comment by Rosso Maltese (asettico) - Thursday, 08 July 2010, 15:18 GMT+2
Ehm... just some information more...

The error message is:

make: *** No rule to make target `/home/asettico-9.10/Sviluppo/rockbox/rockbox/build_bootloader/settings.h', needed by `/home/asettico-9.10/Sviluppo/rockbox/rockbox/build_bootloader/firmware/target/arm/ipod/button-clickwheel.o'. Stop.

I think the path build_bootloader/settings.h should be apps/settings.h.
Comment by Fred Bauer (freddyb) - Thursday, 08 July 2010, 15:53 GMT+2
Crap. It needed to have the parts that read global_settings #ifdef'd so they just use a fixed value in the boot loader because settings aren't available yet. (This patch is not likely to be accepted anyway.)
   ipod_wheel_speedv5.diff (5.8 KiB) 
 apps/lang/english.lang                       |   14 ++++++++++++++
 apps/settings.h                              |    4 ++++
 apps/menus/settings_menu.c                   |    7 +++++++
 apps/settings_list.c                         |    5 +++++
 firmware/export/button.h                     |    4 ++++
 firmware/target/arm/ipod/button-clickwheel.c |   27 ++++++++++++++-------------
 6 files changed, 48 insertions(+), 13 deletions(-)

Loading...