Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10394 - Add a "Move after current" item to the playlist viewer contextual menu

Attached to Project: Rockbox
Opened by Doru Barbu (fragilematter) - Monday, 29 June 2009, 16:36 GMT+2
Task Type Patches
Category Playlists
Status Unconfirmed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

This patch implements a menu function to the playlist viewer's contextual menu that moves the selected track after the current playing track. It is especially useful as a simple queuing method.

I have tried to properly handle the situation in which the current playing track is the last in the playlist, but since I don't know exactly how (when) the playlist indexes are updated I wasn't able to do much in that respect, any help is very welcomed.

Since this patch adds the LANG_MOVE_AFTER_CURRENT string, I have also attached a diff with updates to the English and the Romanian translation file.
   move_after_curr.diff (1.9 KiB) 
 apps/playlist_viewer.c |   20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

   move_after_curr_lang.diff (1.2 KiB) 
 apps/lang/english.lang   |   14 ++++++++++++++
 apps/lang/romaneste.lang |   14 ++++++++++++++
 2 files changed, 28 insertions(+)

This task depends upon

Comment by Doru Barbu (fragilematter) - Monday, 29 June 2009, 17:12 GMT+2
Fixed some serious holes in my logic and the code. Not the code handles trying to move the current playing track after itself (by doing nothing). If the current playing track is the last in the playlist the moved tracks seem to go on the first position in the playlist, despite my efforts.
   move_after_curr.diff (1.9 KiB) 
 apps/playlist_viewer.c |   20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

Loading...