Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10397 - mkamsboot: little code rewrite to have better output

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Monday, 29 June 2009, 22:16 GMT+2
Last edited by Thomas Martitz (kugel.) - Sunday, 05 July 2009, 04:33 GMT+2
Task Type Patches
Category Battery/Charging
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.3
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This rewrites the code to extend the output of the (standalone) mkamsboot, so that OF version and model version (e.g. v4 for m200v4) are shown.
   mkamsboot.vc.diff (11.7 KiB) 
 rbutil/mkamsboot/mkamsboot.h |   13 +++-
 rbutil/mkamsboot/mkamsboot.c |  131 +++++++++++++++++++++++--------------------
 2 files changed, 83 insertions(+), 61 deletions(-)

This task depends upon

Closed by  Thomas Martitz (kugel.)
Sunday, 05 July 2009, 04:33 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed as of r21648. Thanks Rafael.
Comment by Thomas Martitz (kugel.) - Monday, 29 June 2009, 22:27 GMT+2
See, I mixed fw_revision and hw_revision in 1 place :(
   mkamsboot.vc2.diff (11.8 KiB) 
 rbutil/mkamsboot/mkamsboot.h |   13 +++-
 rbutil/mkamsboot/mkamsboot.c |  133 +++++++++++++++++++++++--------------------
 2 files changed, 84 insertions(+), 62 deletions(-)

Comment by Rafaël Carré (funman) - Wednesday, 01 July 2009, 23:19 GMT+2
s/clop/clip/ in mkamsboot.h

fw_version and hw_version should go in separate arrays since they don't change between different firmwares for a same model

If you want I can do it when i find some time

Comment by Thomas Martitz (kugel.) - Wednesday, 01 July 2009, 23:20 GMT+2
I thought we agreed on doing this sort of cosmetics later :)

This patch is about giving more output (including OF version) which needs slight code changes.
Comment by Rafaël Carré (funman) - Thursday, 02 July 2009, 02:25 GMT+2
- Adds the changes mentioned.
- Change a bit the text of a string (Beginning to patch the firmware => Firmware patching has begun!)
- Add newlines after this string, and before last line of output

Is it ok for you?
   mkamsboot.vc3.diff (12.2 KiB) 
 b/rbutil/mkamsboot/mkamsboot.c |  143 +++++++++++++++++++++--------------------
 b/rbutil/mkamsboot/mkamsboot.h |   11 ++-
 2 files changed, 85 insertions(+), 69 deletions(-)

Comment by Thomas Martitz (kugel.) - Thursday, 02 July 2009, 02:29 GMT+2
Surely it is ok, just make sure it still works! :)
Comment by Rafaël Carré (funman) - Thursday, 02 July 2009, 11:15 GMT+2
[INFO] Original firmware MD5 checksum match
[INFO] Model: Sansa Clip v2 (v2) - Firmware version: 2.01.32
[ERR] Model name "clv2" not found in rockbox.sansa
[ERR] Could not load rockbox.sansa

Normal since it was scrambled with "clip", but perhaps the message could be better.

Also perhaps the hw_revision could be merged into the model name ? "Sansa Clip v2 (v2)"
Comment by Thomas Martitz (kugel.) - Thursday, 02 July 2009, 13:05 GMT+2
I'd drop the v2 actually.

Loading...