Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10416 - Pure Data for Rockbox plugin

Attached to Project: Rockbox
Opened by Wincent Balin (wincent) - Wednesday, 08 July 2009, 22:26 GMT+2
Last edited by Peter D'Hoye (petur) - Thursday, 23 July 2009, 23:38 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type SW-codec
Severity Low
Priority Normal
Reported Version Version 3.3
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

PDBox plug-in is working with pdpod_test.pd file from the PureData.zip archive (download it from here: http://www.ipodlinux.org/wiki/PdPod ).

The first patch is the diff to the current source tree.

The second patch is the rockbox integration of the PDBox plug-in.
   pdbox-3-working-simple-test.diff (17.4 KiB) 
 apps/plugins/pdbox/pdbox.h                   |   26 ++--
 apps/plugins/pdbox/PDa/src/d_ugen.c          |    1 
 apps/plugins/pdbox/PDa/src/s_audio_rockbox.c |  159 +++++++++++++++++----------
 apps/plugins/pdbox/PDa/src/m_class.c         |    7 +
 apps/plugins/pdbox/pdbox-func.c              |   45 +++++--
 apps/plugins/pdbox/pdbox.c                   |  119 ++++++++------------
 6 files changed, 205 insertions(+), 152 deletions(-)

   pdbox-3-working-system-integration.diff (1 KiB) 
 apps/plugins/CATEGORIES     |    2 +-
 apps/plugins/SUBDIRS        |    1 +
 apps/plugins/viewers.config |    2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

This task depends upon

Closed by  Peter D'Hoye (petur)
Thursday, 23 July 2009, 23:38 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  last pdbox patch, you can commit changes yourself from now on ;)
Comment by Wincent Balin (wincent) - Friday, 10 July 2009, 01:20 GMT+2
If http://www.ipodlinux.org/ does not work, you might want to get the .pd files (unpacked) from http://trac.katastrophos.net/PDQt/browser/trunk/PureData .
Comment by Peter D'Hoye (petur) - Saturday, 11 July 2009, 22:53 GMT+2
Wincent, what are the exact requirements for pdbox to run? Display, memory, cpu,...
I ask this because you added it now for targets with bitmap displays except the mrobe 500

I would think it should be more near mpegplayer, because of the memory requirements.
Comment by Wincent Balin (wincent) - Sunday, 12 July 2009, 01:50 GMT+2
You are right. Also, domonoky tried to compile pdbox for Sansa e200, but pdbox turned out to be too large. Therefore I think we should wait with the inclusion into the build process a little, till I make some changes to get pdbox somewhat smaller.

I attach a patch which makes the file pdbox-3-working-system-integration.diff obsolete.
   pdbox-3-working-system-integration2.diff (0.7 KiB) 
 apps/plugins/CATEGORIES     |    2 +-
 apps/plugins/viewers.config |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comment by Peter D'Hoye (petur) - Sunday, 12 July 2009, 21:01 GMT+2
patches committed
Comment by Wincent Balin (wincent) - Sunday, 12 July 2009, 21:04 GMT+2
This is a bugfix for warnings about strict aliasing. Basically, pointer casts were replaced with conversions through float-int-unions.
   pdbox-3-working-strict-aliasing-bugfix.diff (3.8 KiB) 
 apps/plugins/pdbox/pdbox.h               |    5 +++++
 apps/plugins/pdbox/PDa/src/d_soundfile.c |   12 ++++++++++++
 apps/plugins/pdbox/PDa/intern/sqrt~.c    |    6 ++++++
 apps/plugins/pdbox/PDa/intern/rsqrt~.c   |   30 ++++++++++++++++++++++++++++++
 4 files changed, 53 insertions(+)

Comment by Peter D'Hoye (petur) - Sunday, 12 July 2009, 21:21 GMT+2
committed as well :)
Comment by Wincent Balin (wincent) - Tuesday, 21 July 2009, 03:46 GMT+2
Cleaned up unneeded prototypes in s_path.c
   pdbox-4-01-s_path-cleaned-prototypes.diff (0.5 KiB) 
 apps/plugins/pdbox/PDa/src/s_path.c |    9 ---------
 1 file changed, 9 deletions(-)

Comment by Wincent Balin (wincent) - Tuesday, 21 July 2009, 14:55 GMT+2
TLSF memory allocator imported. Examples were left out. There are some printf-s in the source which will be commented out in the later patch.
   pdbox-4-02-TLSF-2.4.4-added.diff (87.2 KiB) 
 apps/plugins/pdbox/TLSF-2.4.4/GPL.txt      |  280 ++++++++
 apps/plugins/pdbox/TLSF-2.4.4/TODO         |    9 
 apps/plugins/pdbox/TLSF-2.4.4/src/tlsf.c   |  995 +++++++++++++++++++++++++++++
 apps/plugins/pdbox/TLSF-2.4.4/src/target.h |   12 
 apps/plugins/pdbox/TLSF-2.4.4/src/Makefile |   21 
 apps/plugins/pdbox/TLSF-2.4.4/src/tlsf.h   |   39 +
 apps/plugins/pdbox/TLSF-2.4.4/Changelog    |  119 +++
 apps/plugins/pdbox/TLSF-2.4.4/COPYING      |   23 
 apps/plugins/pdbox/TLSF-2.4.4/LGPL-2.1.txt |  510 ++++++++++++++
 apps/plugins/pdbox/TLSF-2.4.4/README       |  163 ++++
 10 files changed, 2171 insertions(+)

Comment by Wincent Balin (wincent) - Tuesday, 21 July 2009, 15:39 GMT+2
The patch added is the corrected version of the previous one -- meaning that it makes it obsolete!
   pdbox-4-02-TLSF-2.4.4-added-corrected.diff (44.5 KiB) 
 apps/plugins/pdbox/TLSF-2.4.4/TODO         |    9 
 apps/plugins/pdbox/TLSF-2.4.4/src/tlsf.c   |  995 +++++++++++++++++++++++++++++
 apps/plugins/pdbox/TLSF-2.4.4/src/target.h |   12 
 apps/plugins/pdbox/TLSF-2.4.4/src/tlsf.h   |   39 +
 apps/plugins/pdbox/TLSF-2.4.4/Changelog    |  119 +++
 apps/plugins/pdbox/TLSF-2.4.4/COPYING      |   23 
 apps/plugins/pdbox/TLSF-2.4.4/README       |  163 ++++
 7 files changed, 1360 insertions(+)

Comment by Peter D'Hoye (petur) - Tuesday, 21 July 2009, 15:53 GMT+2
same patch with svn properties corrected
   p.diff (46 KiB) 
 apps/plugins/pdbox/TLSF-2.4.4/TODO         |    9 
 apps/plugins/pdbox/TLSF-2.4.4/Changelog    |  119 +++
 apps/plugins/pdbox/TLSF-2.4.4/src/tlsf.c   |  995 +++++++++++++++++++++++++++++
 apps/plugins/pdbox/TLSF-2.4.4/src/target.h |   12 
 apps/plugins/pdbox/TLSF-2.4.4/src/tlsf.h   |   39 +
 apps/plugins/pdbox/TLSF-2.4.4/COPYING      |   23 
 apps/plugins/pdbox/TLSF-2.4.4/README       |  163 ++++
 7 files changed, 1360 insertions(+)

Comment by Peter D'Hoye (petur) - Tuesday, 21 July 2009, 15:57 GMT+2
tip: to change the properties for a lot of files, do this:

svn propset -R svn:keywords 'Author Date Id Revision' *
svn propset -R svn:eol-style native *
Comment by Wincent Balin (wincent) - Tuesday, 21 July 2009, 17:41 GMT+2
Made TLSF compile without warnings.
   pdbox-4-03-TLSF-warnings-removed.diff (1.1 KiB) 
 apps/plugins/pdbox/TLSF-2.4.4/src/tlsf.c |   12 ++++++++++++
 1 file changed, 12 insertions(+)

Comment by Wincent Balin (wincent) - Tuesday, 21 July 2009, 17:55 GMT+2
Replaced dbestfit with TLSF. Left references to wfirstfit in the source. Made some functions use local variables instead of allocated memory. Increased size of both the audio output buffer to remove crackling in resulting sound and the core and GUI thread stacks to diminish possibility of an error because of insufficient memory.
   pdbox-4-04-replaced-dbestfit-with-TLSF.diff (76.5 KiB) 
 apps/plugins/pdbox/pdbox.h                 |   45 +
 apps/plugins/pdbox/SOURCES                 |   10 
 apps/plugins/pdbox/dbestfit-3.3/malloc.man |   95 ---
 apps/plugins/pdbox/dbestfit-3.3/bysize.c   |  428 -----------------
 apps/plugins/pdbox/dbestfit-3.3/Malloc.c   |  200 --------
 apps/plugins/pdbox/dbestfit-3.3/bmalloc.c  |  371 ---------------
 apps/plugins/pdbox/dbestfit-3.3/bysize.h   |    4 
 apps/plugins/pdbox/dbestfit-3.3/dmalloc.c  |  711 -----------------------------
 apps/plugins/pdbox/dbestfit-3.3/README     |   21 
 apps/plugins/pdbox/dbestfit-3.3/bmalloc.h  |    5 
 apps/plugins/pdbox/dbestfit-3.3/dmalloc.h  |   12 
 apps/plugins/pdbox/dbestfit-3.3/FILES      |   15 
 apps/plugins/pdbox/dbestfit-3.3/thoughts   |  170 ------
 apps/plugins/pdbox/dbestfit-3.3/mytest.c   |   69 --
 apps/plugins/pdbox/dbestfit-3.3/CHANGES    |   12 
 apps/plugins/pdbox/dbestfit-3.3/dmytest.c  |  138 -----
 apps/plugins/pdbox/dbestfit-3.3/Makefile   |   38 -
 apps/plugins/pdbox/pdbox-func.c            |   29 -
 apps/plugins/pdbox/pdbox.make              |    2 
 apps/plugins/pdbox/pdbox.c                 |   93 ++-
 20 files changed, 112 insertions(+), 2356 deletions(-)

Loading...