Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10422 - [aiff/wav codec] rework aiff codec and wav codec

Attached to Project: Rockbox
Opened by Yoshihisa Uchida (Uchida) - Friday, 10 July 2009, 13:58 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Wednesday, 27 January 2010, 18:28 GMT+2
Task Type Patches
Category Codecs
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

For wav codec, it is difficult to support to various formats.

The source file was divided so that it might become easy to respond to various formats.

I corrected processing that decoded as doing by libpcms.a.

For aiff codec. I corrected that the file was decoded by using libpcms.a.
   rb_aiff_wav.patch (78.1 KiB)
 b/apps/codecs/aiff.c                    |  213 +++++-----
 b/apps/codecs/codecs.make               |    3 
 b/apps/codecs/wav.c                     |  650 ++++++--------------------------
 b/apps/metadata/aiff.c                  |    2 
 b/apps/codecs/libpcms/SOURCES           |    3 
 b/apps/codecs/libpcms/dvi_adpcm.c       |  309 +++++++++++++++
 b/apps/codecs/libpcms/itut_g711.c       |  203 +++++++++
 b/apps/codecs/libpcms/libpcms.make      |   25 +
 b/apps/codecs/libpcms/linear_pcm.c      |  163 ++++++++
 b/apps/codecs/libpcms/pcm_common.h      |  120 +++++
 b/apps/codecs/libpcms/support_formats.h |   37 +
 11 files changed, 1115 insertions(+), 613 deletions(-)

This task depends upon

View Dependency Graph

This task blocks these from closing
 FS#10433 - Add Sun Audio codec 
Closed by  MichaelGiacomelli (saratoga)
Wednesday, 27 January 2010, 18:28 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Accepted in r24346.
Comment by MichaelGiacomelli (saratoga) - Friday, 22 January 2010, 03:50 GMT+2
Resync with the following change:

* Fix warnings on 64 bit targets
* Rename "libpcms" to "libpcm" which I think is a little more clear

Yoshihisa:

Are you still following this? If so, and you have no complaints, I'll commit it after the 3.5 feature freeze is over.
   libpcmv2.patch (78.3 KiB)
 apps/metadata/aiff.c                 |    2 
 apps/codecs/aiff.c                   |  213 ++++++-----
 apps/codecs/libpcm/libpcm.make       |   25 +
 apps/codecs/libpcm/SOURCES           |    3 
 apps/codecs/libpcm/itut_g711.c       |  203 +++++++++++
 apps/codecs/libpcm/dvi_adpcm.c       |  309 ++++++++++++++++
 apps/codecs/libpcm/linear_pcm.c      |  163 ++++++++
 apps/codecs/libpcm/support_formats.h |   37 ++
 apps/codecs/libpcm/pcm_common.h      |  120 ++++++
 apps/codecs/codecs.make              |    5 
 apps/codecs/wav.c                    |  644 ++++++-----------------------------
 11 files changed, 1114 insertions(+), 610 deletions(-)

Loading...