Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10425 - [aiff/wav codec] rework DVI ADPCM and supports some IMA ADPCM series formats

Attached to Project: Rockbox
Opened by Yoshihisa Uchida (Uchida) - Friday, 10 July 2009, 14:59 GMT+2
Last edited by Maurus Cuelenaere (mcuelenaere) - Saturday, 20 February 2010, 13:04 GMT+2
Task Type Patches
Category Codecs
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

DVI ADPCM decoding logic reworked.
- supports 2 and 5 bitspersample.
- I corrected the problem not played normally for bitspersample is 3.

And more, the following IMA ADPCM series formats support:
- QuickTime IMA ADPCM (AIFF codec)
- Adobe Flash ADPCM (wav codec)
- XBOX ADPCM (wav codec)

It is necessary to apply the patch of  FS#10422 ,  FS#10423 ,  FS#10424 .
This task depends upon

Closed by  Maurus Cuelenaere (mcuelenaere)
Saturday, 20 February 2010, 13:04 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  In r24782.
Comment by Yoshihisa Uchida (Uchida) - Friday, 10 July 2009, 15:00 GMT+2
Sorry I missed to upload of the patch file.
   rb_ima_adpcms.patch (42.1 KiB) 
 codecs/aiff.c                     |    4 
 codecs/libpcms/SOURCES            |    3 
 codecs/libpcms/dvi_adpcm.c        |  403 +++++++++++++++++---------------------
 codecs/libpcms/ima_adpcm_common.c |  169 +++++++++++++++
 codecs/libpcms/ima_adpcm_common.h |   32 +++
 codecs/libpcms/qt_ima_adpcm.c     |  118 +++++++++++
 codecs/libpcms/support_formats.h  |    8 
 codecs/libpcms/swf_adpcm.c        |  198 ++++++++++++++++++
 codecs/wav.c                      |    6 
 metadata/aiff.c                   |   23 +-
 metadata/wave.c                   |   10 
 11 files changed, 749 insertions(+), 225 deletions(-)

Comment by Yoshihisa Uchida (Uchida) - Tuesday, 16 February 2010, 10:17 GMT+2
I send new patch.

changes
- sync r24691
- sync new  FS#10424 
- I corrected to seek the adobe SWF adpcm format wave file.
   rb_ima_adpcms_2.patch (43.1 KiB) 
 codecs/aiff.c                    |    6 
 codecs/libpcm/SOURCES            |    3 
 codecs/libpcm/dvi_adpcm.c        |  413 ++++++++++++++++++++-------------------
 codecs/libpcm/ima_adpcm_common.c |  171 ++++++++++++++++
 codecs/libpcm/ima_adpcm_common.h |   32 +++
 codecs/libpcm/qt_ima_adpcm.c     |  136 ++++++++++++
 codecs/libpcm/support_formats.h  |    8 
 codecs/libpcm/swf_adpcm.c        |  233 ++++++++++++++++++++++
 codecs/wav.c                     |    6 
 metadata/aiff.c                  |   23 +-
 metadata/wave.c                  |   10 
 11 files changed, 834 insertions(+), 207 deletions(-)

Comment by Yoshihisa Uchida (Uchida) - Saturday, 20 February 2010, 11:02 GMT+2
I commit this patch (see r24782) but I cannot close my task.
please close this task.

Loading...