Rockbox

Tasklist

FS#10428 - ipodpatcher build failure on big-endian

Attached to Project: Rockbox
Opened by Alyssa Milburn (fuzzie) - Friday, 10 July 2009, 18:14 GMT
Last edited by Dave Chapman (linuxstb) - Tuesday, 04 August 2009, 20:04 GMT
Task Type Patches
Category Rbutil
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Version 3.3
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

ipodpatcher doesn't build on big-endian Linux because the htole32 etc functions it provides are macros in the system header files.

I attached my local fix which simply renames the functions ('static' is added for consistency too, but it builds fine without that change), but maybe it would be better fixed in another way (#undefing the macros?). This is untested on anything except big-endian Linux but it doesn't seem like it could be a problem anywhere else.
This task depends upon

Closed by  Dave Chapman (linuxstb)
Tuesday, 04 August 2009, 20:04 GMT
Reason for closing:  Accepted
Additional comments about closing:  I implemented a coincidentally identical fix without seeing your patch and committed as r22164. Thanks anyway.

Loading...