This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#10428 - ipodpatcher build failure on big-endian
Attached to Project:
Rockbox
Opened by Alyssa Milburn (fuzzie) - Friday, 10 July 2009, 20:14 GMT+2
Last edited by Dave Chapman (linuxstb) - Tuesday, 04 August 2009, 22:04 GMT+2
Opened by Alyssa Milburn (fuzzie) - Friday, 10 July 2009, 20:14 GMT+2
Last edited by Dave Chapman (linuxstb) - Tuesday, 04 August 2009, 22:04 GMT+2
|
Detailsipodpatcher doesn't build on big-endian Linux because the htole32 etc functions it provides are macros in the system header files.
I attached my local fix which simply renames the functions ('static' is added for consistency too, but it builds fine without that change), but maybe it would be better fixed in another way (#undefing the macros?). This is untested on anything except big-endian Linux but it doesn't seem like it could be a problem anywhere else. |
This task depends upon
Closed by Dave Chapman (linuxstb)
Tuesday, 04 August 2009, 22:04 GMT+2
Reason for closing: Accepted
Additional comments about closing: I implemented a coincidentally identical fix without seeing your patch and committed as r22164. Thanks anyway.
Tuesday, 04 August 2009, 22:04 GMT+2
Reason for closing: Accepted
Additional comments about closing: I implemented a coincidentally identical fix without seeing your patch and committed as r22164. Thanks anyway.