This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#10432 - Add Yamaha SMAF codec
Attached to Project:
Rockbox
Opened by Yoshihisa Uchida (Uchida) - Sunday, 12 July 2009, 08:34 GMT+2
Last edited by Yoshihisa Uchida (Uchida) - Wednesday, 17 March 2010, 13:28 GMT+2
Opened by Yoshihisa Uchida (Uchida) - Sunday, 12 July 2009, 08:34 GMT+2
Last edited by Yoshihisa Uchida (Uchida) - Wednesday, 17 March 2010, 13:28 GMT+2
|
DetailsYamaha SMAF codec adds.
SMAF (.mmf extension file) is used as the format of the music file for the cellular phone. This codec supports only wave data (ADPCM and PCM). It does not support MIDI, picture, and movie. It is necessary to apply patchs of 
rb_smaf.patch
(24.9 KiB)
b/apps/SOURCES | 1 b/apps/codecs/SOURCES | 1 b/apps/codecs/codecs.make | 1 b/apps/filetypes.c | 1 b/apps/metadata.c | 11 + b/apps/metadata.h | 1 b/apps/metadata/metadata_parsers.h | 1 b/apps/codecs/smaf.c | 388 +++++++++++++++++++++++++++++++++++++ b/apps/metadata/smaf.c | 369 +++++++++++++++++++++++++++++++++++ 9 files changed, 774 insertions(+) |
This task depends upon
Closed by Yoshihisa Uchida (Uchida)
Wednesday, 17 March 2010, 13:28 GMT+2
Reason for closing: Accepted
Additional comments about closing: new smaf codec commits and manual updates.
Wednesday, 17 March 2010, 13:28 GMT+2
Reason for closing: Accepted
Additional comments about closing: new smaf codec commits and manual updates.
FS#10422,FS#10423,FS#10424, andFS#10425. And after this task's patch file applies.When SMAF codec build failure still, please tell me the build environment.
I wasn't able to apply fs # 10424 directly after fs#10423. For some reason though I was able to apply it after I applied fs #10425.
However, I have now applied all the patches that this patch depends on, and it still won't apply.
I also can't apply fs #10433.
So the patches of yours that won't apply are fs#10432 and fs #10433.
I am running a cygwin build environment.
In my build environment, all patches can be normally applied.
I operate the follwoing:
$ cd rockbox (~/rockbox is stored Rockbox souces)
$ patch -p1 < ../rb_aiff_wav.patch (
FS#10422)$ patch -p1 < ../rb_ieee_float.patch (
FS#10423)$ patch -p1 < ../rb_adpcms.patch (
FS#10424)$ patch -p1 < ../rb_ima_adpcms.patch (
FS#10425)$ patch -p1 < ../rb_smaf.patch (
FS#10432)My build environment
OS
Linux
Windows + Cygwin
Source
r21903
FS#10422-FS#10425, andFS#10432).I have just tried to apply them, and with the combined dif for this task, I am getting a lot of errors saying the files already exist. I assume this is because they were created by the other diff? is it possible for you to simply put up a diff of all your codecs to date that will apply without any problems? as at the moment I seem to be getting problems when I try to apply this combined diff.
I would simply like to be able to apply all your codec patches to date in one go.
changes
- sync r24691
- sync new
FS#10424,FS#10425patchPlease apply new
FS#10424andFS#10425patch before applying this patch.And one more thing: it's good to say in what SVN revision the patch has been committed.
static unsigned char smafbuf[1024];
The metadata parser are loaded all the time, unlike the codecs (which load only when needed). This is a very large buffer to leave allocated all the time in rockbox even if no SMAF files are used. Putting this on the stack would allow the memory to be freed after the parser is done.
- title/artist/composer are stored id3v2buf instead of id3v1buf.
- I corrected that there is no problem even if audio data is at which position from the head.
Please verify it.
Because the increase size of the firmware after it applies is large (about + 1k), is committing impossible?
I check and change logics more (sigh...).