Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10440 - Add the possibility to toggle the pitch changing mode in the other direction

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Thursday, 16 July 2009, 01:23 GMT+2
Task Type Patches
Category User Interface
Status New
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.3
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

As of r21894, the pitch changing mode (in the pitch screen) can only be toggled (cycled through) in one direction. However it would be handy to be able to cycle in the other direction to change procentual vs. semitone while still staying in the time stretch mode. This patch adds such a possibility.

The key mappings is only defined for H1xx and H3xx (as a long press of Mode). Please add keys for other platfroms.
   pitch_toggle_mode_back.diff (3.2 KiB) 
 apps/action.h                   |    1 +
 apps/gui/pitchscreen.c          |   38 ++++++++++++++++++++++++--------------
 apps/keymaps/keymap-h1x0_h3x0.c |    3 ++-
 3 files changed, 27 insertions(+), 15 deletions(-)

This task depends upon

Comment by Alexander Levin (fml2) - Friday, 17 July 2009, 12:16 GMT+2
Added key mappings to other players (where it seemed unambiguous to me). The principle is: change "toggle forth" to what it was before + "BUTTON_RELEASE"; assign "toggle back" to the same button as "toggle forth", but with "BUTTON_REPEAT".

BTW: I noticed that the toggle action is not defined for the H100 and H300 remotes. But as nobody complains, I assume nobody uses it.
   pitch_toggle_mode_back.2.diff (17.2 KiB) 
 apps/action.h                    |    1 
 apps/gui/pitchscreen.c           |   48 ++++++++++++++++++++++++++++-----------
 apps/keymaps/keymap-m3.c         |    6 +++-
 apps/keymaps/keymap-h1x0_h3x0.c  |    3 +-
 apps/keymaps/keymap-gigabeat-s.c |    3 +-
 apps/keymaps/keymap-gigabeat.c   |    3 +-
 apps/keymaps/keymap-c200.c       |    3 +-
 apps/keymaps/keymap-recorder.c   |    3 +-
 apps/keymaps/keymap-e200.c       |    3 +-
 apps/keymaps/keymap-clip.c       |    1 
 apps/keymaps/keymap-av300.c      |    3 +-
 apps/keymaps/keymap-ipod.c       |    3 +-
 apps/keymaps/keymap-x5.c         |    6 +++-
 apps/keymaps/keymap-mr100.c      |    3 +-
 apps/keymaps/keymap-meizu-m6sl.c |    3 +-
 apps/keymaps/keymap-fuze.c       |    3 +-
 apps/keymaps/keymap-hdd1630.c    |    3 +-
 17 files changed, 69 insertions(+), 29 deletions(-)

Loading...