This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#10468 - USB HID: Show keypad mode on screen
Attached to Project:
Rockbox
Opened by Tomer Shalev (tomers) - Sunday, 26 July 2009, 09:30 GMT+2
Last edited by Tomer Shalev (tomers) - Wednesday, 30 September 2009, 15:26 GMT+2
Opened by Tomer Shalev (tomers) - Sunday, 26 July 2009, 09:30 GMT+2
Last edited by Tomer Shalev (tomers) - Wednesday, 30 September 2009, 15:26 GMT+2
|
DetailsThis patch add support for changing keypad mapping to keys sent to the host computer while the DAP is connected through USB.
The user can iterate over the different keypad modes by pressing a key (e200: REC key). The different modes are: * Media Player (Control volume, Pause/Play, Stop, Next/Previous tracks) * PowerPoint (Start Presentation, Next/Previous slide, Black/White screen, etc) * Acrobat Reader (Next/Previous Page/Screen, Full Screen, Scroll Up/Down) Additional modes can be easily added. The current mode will be shown on screen (tested on e200 - need further testing on different platforms). 
usb_hid_show_keymap.diff
(48.1 KiB)
apps/screens.c | 238 +++++++++++++++++++++++++++----------- apps/action.h | 22 ++- apps/keymaps/keymap-ondavx747.c | 14 +- apps/keymaps/keymap-c100.c | 17 +- apps/keymaps/keymap-gigabeat-s.c | 53 ++++---- apps/keymaps/keymap-c200.c | 24 ++- apps/keymaps/keymap-e200.c | 28 ++-- apps/keymaps/keymap-sa9200.c | 41 +++--- apps/keymaps/keymap-touchscreen.c | 23 ++- apps/keymaps/keymap-clip.c | 28 ++-- apps/keymaps/keymap-h10.c | 39 +++--- apps/keymaps/keymap-ipod.c | 42 +++--- apps/keymaps/keymap-mr100.c | 51 +++++--- apps/keymaps/keymap-hdd1630.c | 32 ++--- firmware/usbstack/usb_hid.c | 16 +- 15 files changed, 433 insertions(+), 235 deletions(-) |
This task depends upon
Closed by Tomer Shalev (tomers)
Wednesday, 30 September 2009, 15:26 GMT+2
Reason for closing: Accepted
Additional comments about closing: Committed in r22852-22856
Wednesday, 30 September 2009, 15:26 GMT+2
Reason for closing: Accepted
Additional comments about closing: Committed in r22852-22856
This is especially helpful since many players don't have a record button, and so have even less available buttons to be able to spare one for this.
I think this is a good remark. I've implemented a system setting for this feature, and a manual section for it (currently enabled only in e200 - should define option USB_ENABLE_HID in manual/platform/*.tex where relevant).
Attached patch contains these additions.
More generally, I'm not sure how far we should take this built-in HID mode. Personally, I think the remote_control plugin is the proper place for all this.
Removed support for proprietary applications, as per Frank's suggestion.
Now supports three modes: Multimedia, Presentation and Browser.
Documentation relates to OpenOffice Impress and Firefox as example applications.
* Save settings once, on USB disconnect, instead on each keypad mode change.
* Remove redundant gui statusbar drawing calls
-Extract the usb keymap mode logic into apps/usb_keymaps.[ch], thus make apps/screens.c neatier.
This patch tested extensively on e200. I guess this patch is stable and ready for testing. I would welcome any feedback, especially from users using other platforms.
I would appreciate if one of the committers (gevaerts?) will find the time to consider it for committing after we receive enough feedback.
Thanks,
Tomer
- Added mouse acceleration which mouse mode more usable.
- Support for iterating backwards over keypad modes using a long press.
- Removed support for middle mouse button
- Add support for left/right mouse dragging
- Fixed using define HAVE_USBSTACK instead of USB_ENABLE_HID
- Fixed some wrong HID buttons on various targets
- Add mouse keymaps for the following targets:
hdd1630; sa9200; ipod; gigabeat-s; clip; c100; c200; e200 (owners: please test and report)
- Added manual section with proper keymaps for all relevant platforms.
No further enhancements are expected.
- Use #define HAVE_USB_HID_MOUSE for target with sufficient number of keys to have a usable mouse emulation