Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10485 - Some changes for brickmania

Attached to Project: Rockbox
Opened by Asael Reiter (AsaelReiter) - Monday, 03 August 2009, 15:34 GMT+2
Last edited by Tomer Shalev (tomers) - Monday, 22 February 2010, 05:37 GMT+2
Task Type Patches
Category Games
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.3
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

After adding the enlarge&shrink powerups ( FS#10463 ), I wanted to make it really grow and shrink (not only 3 sets of pads).
During the working on that, I notice some code that I thought I can improve, so I rewrite some parts of the code.

To use this code, you need the BMPs of the parts of the pad.
(brickmania_left_pads,brickmania_middle_pads,brickmania_right_pads)
If your resolution is 220x176 or monochrome, you can use attached files (even they are a little ugly).
However, don't forget to add them to apps/plugins/bitmaps/native/SOURCES
   bm.diff (47.1 KiB) 
 apps/plugins/brickmania.c |  704 ++++++++++++++++++----------------------------
 1 file changed, 281 insertions(+), 423 deletions(-)

   brickmania_left_pads.112x64x1.bmp (0.1 KiB)
   brickmania_left_pads.220x176x16.bmp (0.2 KiB)
   brickmania_middle_pads.112x64x1.bmp (0.1 KiB)
   brickmania_middle_pads.220x176x16.bmp (0.6 KiB)
   brickmania_right_pads.112x64x1.bmp (0.1 KiB)
   brickmania_right_pads.220x176x16.bmp (0.3 KiB)
This task depends upon

Closed by  Tomer Shalev (tomers)
Monday, 22 February 2010, 05:37 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Partly accepted. The author will open separate Flyspray items for the changes that were not committed yet.
Comment by Asael Reiter (AsaelReiter) - Monday, 03 August 2009, 19:08 GMT+2
Some fixings.
   bm.diff (44.9 KiB) 
 apps/plugins/brickmania.c |  672 +++++++++++++++++-----------------------------
 1 file changed, 250 insertions(+), 422 deletions(-)

Comment by Asael Reiter (AsaelReiter) - Tuesday, 04 August 2009, 01:55 GMT+2
Some change of the ball-brick check.
   bm.diff (44.2 KiB) 
 apps/plugins/brickmania.c |  654 ++++++++++++++++------------------------------
 1 file changed, 231 insertions(+), 423 deletions(-)

Comment by Asael Reiter (AsaelReiter) - Thursday, 06 August 2009, 02:31 GMT+2
Some simplification off the powerups.
   bm.diff (44.8 KiB) 
 apps/plugins/brickmania.c |  698 ++++++++++++++++------------------------------
 1 file changed, 257 insertions(+), 441 deletions(-)

Comment by Asael Reiter (AsaelReiter) - Thursday, 06 August 2009, 03:01 GMT+2
Fix the left edge of the paddle.
   bm.diff (44.8 KiB) 
 apps/plugins/brickmania.c |  699 ++++++++++++++++------------------------------
 1 file changed, 258 insertions(+), 441 deletions(-)

Comment by Asael Reiter (AsaelReiter) - Sunday, 09 August 2009, 18:43 GMT+2
Fix the glue
   bm.diff (47.1 KiB) 
 apps/plugins/brickmania.c |  759 +++++++++++++++++-----------------------------
 1 file changed, 283 insertions(+), 476 deletions(-)

Comment by Asael Reiter (AsaelReiter) - Wednesday, 12 August 2009, 19:15 GMT+2
Simplify the fires and the powerups. Fix the saving.
   bm.diff (48.8 KiB) 
 apps/plugins/brickmania.c |  782 ++++++++++++++++++----------------------------
 1 file changed, 306 insertions(+), 476 deletions(-)

Comment by Asael Reiter (AsaelReiter) - Wednesday, 12 August 2009, 22:45 GMT+2
A little fixing.
   bm.diff (51 KiB) 
 apps/plugins/brickmania.c |  871 ++++++++++++++++++----------------------------
 1 file changed, 342 insertions(+), 529 deletions(-)

Comment by Asael Reiter (AsaelReiter) - Sunday, 16 August 2009, 20:11 GMT+2
Simplify the powerups, fire new balls ("B" powerup) from the hit point.
Comment by Asael Reiter (AsaelReiter) - Sunday, 16 August 2009, 20:13 GMT+2
OOPS! here is the file.
   bm.diff (51.1 KiB) 
 apps/plugins/brickmania.c |  872 ++++++++++++++++++----------------------------
 1 file changed, 343 insertions(+), 529 deletions(-)

Comment by Tomer Shalev (tomers) - Wednesday, 17 February 2010, 07:52 GMT+2
Hi Asael,

I would like to commit this patch. Can you please sync it?
This patch is rather large. It would be best if you can split it into several different patches (post them all here). e.g. have a separate patch to replace hard-coded constants with #defines.

Regards,
Tomer
Comment by Asael Reiter (AsaelReiter) - Thursday, 18 February 2010, 18:23 GMT+2
This part of the patch should simplify the way that the fires work.
Someone (kkurbjun?) changed the fire-brick check, to be more smart (I guess it's help when the speed of the fires is more than the height of the bricks).
I did not touch it yet. I will check if I can improve that later.
   bm.diff (7.2 KiB) 
 apps/plugins/brickmania.c |  105 ++++++++++++++++++++++------------------------
 1 file changed, 51 insertions(+), 54 deletions(-)

Comment by Asael Reiter (AsaelReiter) - Friday, 19 February 2010, 01:57 GMT+2
I simplified the fire-brick check.
   bm.diff (7.3 KiB) 
 apps/plugins/brickmania.c |  106 ++++++++++++++++++++--------------------------
 1 file changed, 48 insertions(+), 58 deletions(-)

Comment by Asael Reiter (AsaelReiter) - Friday, 19 February 2010, 15:03 GMT+2
sync to r24771
   bm2.diff (7 KiB) 
 apps/plugins/brickmania.c |  103 ++++++++++++++++++++--------------------------
 1 file changed, 46 insertions(+), 57 deletions(-)

Comment by Tomer Shalev (tomers) - Friday, 19 February 2010, 17:36 GMT+2
bm2.diff with several changes made by me is now committed in r24755.
Asael, Can you please create an updated patch with what is left from the original patch? Thanks

קודד ביום חול ;-)
Comment by Asael Reiter (AsaelReiter) - Sunday, 21 February 2010, 03:30 GMT+2
This patch simplify the powerups (and make them very close to the fires)
By the way, why is 'brick' a one-dimensional array?
If there is no reason, I will change it.
Comment by Asael Reiter (AsaelReiter) - Sunday, 21 February 2010, 03:31 GMT+2
OOPS! I forgot the file :)
   bm.diff (22.9 KiB) 
 rockbox/apps/plugins/brickmania.c |  328 ++++++++++++++++++--------------------
 1 file changed, 163 insertions(+), 165 deletions(-)

Comment by Tomer Shalev (tomers) - Sunday, 21 February 2010, 05:08 GMT+2
> By the way, why is 'brick' a one-dimensional array?
I also wondered about that. If you think it is better to have it two dimensional, please post a patch and we'll see (notice there is the interdiff utility to compare to patches, which allows you to easily develop plugins which are dependent on each other).
Can you please post each of your patches separately, and close this task? It is hard to follow what other modifications this patch contains, and it is not a good practice for one FlySpray item to hold several different patches.

Patch file naming: Please rename bm.diff to something nicer, like brickmania_powerups_rework.diff, this way it will be easier to follow.

FlySpray item naming: 'Some changes for brickmania' is not a very descriptive name.
It will be easier for the committer (me) to just put the FlySpray item's name in the commit log message. In r24755 I've used this item's name as log message and got responses on IRC that I should have used some more descriptive text.


Comment by Asael Reiter (AsaelReiter) - Sunday, 21 February 2010, 13:37 GMT+2
this patch make brick a two dimensional array.
I did not understand how to work with interdiff, so I diffed the versions of brickmania.c
   brickarray.diff (7.1 KiB) 
 brickmania2.c |   54 ++++++++++++++++++++++++------------------------------
 1 file changed, 24 insertions(+), 30 deletions(-)

Comment by Tomer Shalev (tomers) - Sunday, 21 February 2010, 13:55 GMT+2
> this patch make brick a two dimensional array

Asael, I would like to close this FlySpray item. Could you please create a new FS item explicitly for this patch?

Also, please list whatever changes the original patch contains, otherwise it might be forgotten after this FS item is closed.

Thanks, Tomer
Comment by Asael Reiter (AsaelReiter) - Monday, 22 February 2010, 01:42 GMT+2
OK. you can close it. I listed my old changes.

Loading...