Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10488 - Doom - rotate directional keys when screen is rotated

Attached to Project: Rockbox
Opened by Michael Chicoine (mc2739) - Wednesday, 05 August 2009, 15:43 GMT+2
Last edited by Michael Chicoine (mc2739) - Saturday, 20 August 2011, 03:14 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch for the Doom plugin will rotate the directional keys to match the screen rotation.

Screen rotation in Doom is only available for targets where the screen height is greater than the screen width (e200, gigabeat f,x)

Also included is a patch for manual changes for the above and additional cleanup.
   doom-key-rotate.diff (3.6 KiB) 
 apps/plugins/doom/i_video.c |   96 ++++++++++++++++++++++++++++++++++++--------
 1 file changed, 80 insertions(+), 16 deletions(-)

   doom-manual.diff (2.4 KiB) 
 manual/plugins/doom.tex |   24 ++++++++++++++++--------
 1 file changed, 16 insertions(+), 8 deletions(-)

This task depends upon

Closed by  Michael Chicoine (mc2739)
Saturday, 20 August 2011, 03:14 GMT+2
Reason for closing:  Out of Date
Comment by Teruaki Kawashima (teru) - Wednesday, 05 August 2009, 16:58 GMT+2
IIRC, rotate_screen is only defined for targets with portrait LCD.
so, i guess your patch would break other targets than e200 and gigabeat.
patch for manual seems to add rotate option for ipodvideo for which i don't think screen rotation is supported.
or am i misunderstanding something?

this is my old patch tried to do same thing.
   doom-rotate-key.patch (2.8 KiB) 
 apps/plugins/doom/i_video.c  |   42 ++++++++++++++++++++++++++++++++++--------
 apps/plugins/doom/rockdoom.c |    2 ++
 2 files changed, 36 insertions(+), 8 deletions(-)

Comment by Michael Chicoine (mc2739) - Wednesday, 05 August 2009, 17:46 GMT+2
The key patch only changes the key mapping on targets that can rotate the display.

The manual patch is incorrect due to a copy/paste error. The corrected manual patch is attached.
   doom-manual-v2.diff (2.3 KiB) 
 manual/plugins/doom.tex |   24 ++++++++++++++++--------
 1 file changed, 16 insertions(+), 8 deletions(-)

Comment by Michael Chicoine (mc2739) - Wednesday, 05 August 2009, 18:03 GMT+2
Upon further review, you are correct, rotate_screen will not exist if the LCD is not portrait. This updated patch should not cause errors on other targets.
   doom-key-rotate-v2.diff (4.2 KiB) 
 apps/plugins/doom/i_video.c |  116 +++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 110 insertions(+), 6 deletions(-)

Comment by Michael Chicoine (mc2739) - Thursday, 06 August 2009, 07:32 GMT+2
Update again to correct cut/paste & "in too much of a hurry" errors
   doom-key-rotate-v3.diff (3.9 KiB) 
 apps/plugins/doom/i_video.c |  104 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 104 insertions(+)

Loading...