Rockbox

Tasklist

FS#10517 - Add "Patches applied" to System -> Rockbox Info

Attached to Project: Rockbox
Opened by Rosso Maltese (asettico) - Wednesday, 12 August 2009, 22:02 GMT
Last edited by Jonathan Gordon (jdgordon) - Thursday, 05 August 2010, 13:13 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The patch adds an information line in the screen "Rockbox Info" about the patches applied.
The format is very simple: it shows the related FS numbers separated by commas, all in the same row; if it's longer than the LCD width, it scrolls only when selected, as usual. If no patches are applied, the line is not showed at all.
The information is gathered at compile time, running make, and hard coded in the binary, so it grows the memory size just when some patch is found. Only the language and voice files always contain the strings used.

It relies on the existence of files named $(ROOTDIR)/patchinfo/fsN.txt, where N is the related FS number. If a patch file contains also the differences that create this file, the algorithm is fed automagically. Just the file existence is checked, so empty files are valid.

Since the information is stored inside the binary, it can be useful when trying different builds in the same installation, i.e. to investigate differences of the behaviour yields by some patch.

A possible extension on which I'm thinking about is to use the patchinfo files content to list something more, like the FS summary. But in this case should be necessary to put each information one per line, so the height of the screen can grow enough to require the vertical scroll feature.
Since as now I don't know how to manage it (probably is already done, I could add several stub lines, just to exceed the LCD height and see what's going on).

This patch applies to r22278.

Note to italian translators: ho aggiunto la correzione "s/Patch/pec/ig" in tools/voice.pl, ma non sono riuscito a trovare la combinazione giusta per la c dolce finale. Inoltre la e dovrebbe essere grave.
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Thursday, 05 August 2010, 13:13 GMT
Reason for closing:  Rejected
Comment by Jonathan Gordon (jdgordon) - Wednesday, 12 August 2009, 22:18 GMT
There is very little chance this will be accepted... We prefer people dont use custom builds, so if they do, they know which patchs they have added.. Also how is this supposed to work with patches that dont have a FS#?
Comment by Rosso Maltese (asettico) - Wednesday, 12 August 2009, 22:22 GMT
OK, Daniel, I spent some effort on this, but it has been an interesting exercise! ;-)
http://www.rockbox.org/mail/archive/rockbox-archive-2008-02/0236.shtml
Comment by Rosso Maltese (asettico) - Wednesday, 12 August 2009, 22:29 GMT
You can always create "by hands" those files before running make.
For instance, I wrote a sort of wrapper script that update, patch, build, and install. In the patch phase I could add instructions to create those patchinfo files.
Anyway, it was just an exercise, referring to the mail I indicated before.
Comment by Rosso Maltese (asettico) - Wednesday, 12 August 2009, 22:31 GMT
Ops, I misunderstood.
I didn't manage patches outside FS, so always put them in it! ;-)

Loading...