Rockbox

Tasklist

FS#10541 - Wrong value used when changing scroll bar width

Attached to Project: Rockbox
Opened by Rosso Maltese (asettico) - Tuesday, 18 August 2009, 13:35 GMT
Last edited by Jonathan Gordon (jdgordon) - Wednesday, 16 December 2009, 06:02 GMT
Task Type Bugs
Category User Interface
Status Unconfirmed
Assigned To No-one
Operating System All players
Severity Low
Priority Low
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

In the "Scroll bar width" screen, the value used to show the width selected is the previous one, not the current one. The first value change has no effect.
Anyway it seems that the right value is stored: if you select a value and exit by the screen, when you re-enter in it, the width is correct.

Priority low.

Referred to r22406.
This task depends upon

Comment by Maurus Cuelenaere (mcuelenaere) - Tuesday, 18 August 2009, 13:52 GMT
This is probably because the scrollbar gets drawed with the previous value first, and *then* the new value gets set.

Perhaps a callback triggering a redraw of the current screen could solve this..
Comment by Maurus Cuelenaere (mcuelenaere) - Tuesday, 18 August 2009, 22:22 GMT
This was discussed in IRC ( http://www.rockbox.org/irc/log-20090819#00:01:01 and onwards) and concluded as a Won't Fix.

I'll leave this open for now though.
Comment by Alexander Levin (fml2) - Wednesday, 19 August 2009, 11:03 GMT
I'd rather like to have this fixed. Either disable the live update or get it right.
Comment by Rosso Maltese (asettico) - Wednesday, 19 August 2009, 12:38 GMT
If it becomes a hard to fix problem due to settings list implementation, disabling the live update could be acceptable.
In this case, it's sufficient accept the new value and re-enter in the menu to see the changes.

@mcuelenaere: I tried to investigate somehow the settings list, comparing the behaviour with "Backlight" setting.
In this one, there is a callback function that use the selected value in the right way.
In the IRC discussion you indicated in http://www.rockbox.org/tracker/task/10541#comment32131, I can deduce that a callback doing a refresh of the UI is unacceptable or pointless, is it?
Comment by Maurus Cuelenaere (mcuelenaere) - Wednesday, 19 August 2009, 13:18 GMT
asettico: Right, the fix I proposed was doing a redraw after an item gets selected, but this would result in user select item -> code draws list -> code acknowledges users selection -> code redraws list; and that for *every* list in whole Rockbox.

Also this could lead to a small glitch when going from the maximum scrollbar width to the smallest (the scrollbar would be drawed with the max width and the thumb at the top, then redrawed with the thumb at the bottom and then redrawed with the smallest width and the thumb at the bottom; the correct behaviour should leave out the second draw).

Thomas Martitz (kugel) proposed adding another flag (F_LIVEUPDATE) which would do all the above only if that flag was added, I tend to agree with him although that glitch is still there (but this is very minor).
Comment by Dominik Riebeling (bluebrother) - Sunday, 05 June 2011, 11:48 GMT
Confirmed, this is still an issue. Even more interesting when going through the list the original value always seems to produce a wrong width being shown.

Loading...