Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10552 - Cowon D2: pgup/pgdn on minus/plus buttons in text viewer

Attached to Project: Rockbox
Opened by Arago (Arago) - Thursday, 20 August 2009, 22:26 GMT+2
Last edited by Tomer Shalev (tomers) - Wednesday, 24 February 2010, 22:40 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To Tomer Shalev (tomers)
Player Type Another
Severity Low
Priority Normal
Reported Version Version 3.3
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

I have assigned
+ # define VIEWER_PAGE_UP BUTTON_MINUS
+ # define VIEWER_PAGE_DOWN BUTTON_PLUS
in viewer.rock to scroll the text in the reader to the player with damaged sensor but good display (and on a normal player, I think the hardware scroll buttons would all be more comfortable).
   viewer.patch (0.9 KiB) 
 apps/plugins/viewer.c |    2 ++
 1 file changed, 2 insertions(+)

This task depends upon

Closed by  Tomer Shalev (tomers)
Wednesday, 24 February 2010, 22:40 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r24896. Thanks!
I excluded the 'buttons in hold-mode' key mapping.
Arago, if you still like it to be committed, please add your mapping in a separate FlySpray task, and make it dependent on FS#10698.
Comment by Rob Purchase (shotofadds) - Tuesday, 01 September 2009, 22:16 GMT+2
Thanks, that's a sensible addition. The only thing stopping me from adding this to SVN is that all code contributions to Rockbox should be attributed to a real named person - so please can you fill in the Real Name field on your Flyspray profile.
Comment by Arago (Arago) - Sunday, 04 October 2009, 21:23 GMT+2
Sorry, but I dont want to do this. Use my nick instead. And here is new version of this patch (added autoscroll switching using menu button in the Hold mode).

Requires functionality of the buttons in the Hold mode patch by andrewthecoder.
I can't post it here, because this code is not mine, but you can take it with any config on http://iaudiophile.net/forums/showthread.php?t=28467 or on http://uploads.arago.shell.tor.hu/rockbox/hold_buttons_patch.patch
   viewer.patch (0.6 KiB) 
 apps/plugins/viewer.c |    3 +++
 1 file changed, 3 insertions(+)

Comment by Tomer Shalev (tomers) - Monday, 15 February 2010, 07:00 GMT+2
> Sorry, but I dont want to do this. Use my nick instead.

Arago, allow me to quote the docs/CONTRIBUTING file:
<quote>
Credits
-------
We believe in crediting all contributors by name. Before committing a patch to
SVN, we ask that you give us your full real name (no pseudonyms or nicknames)
for adding to the credits list.
</quote>

You seem to have contributed some really good patches, and we would like to see them being committed.
However, we can not to that without your real name. I don't think there is any legal workaround for that.
Would you be kind enough to provide a real name so that your work be committed?

I would like to commit your following patches for start:

10552 Cowon D2: pgup/pgdn on minus/plus buttons in text viewe...
10640 Cowon D2: Rockblox game control using hardware buttons
10642 Cowon D2: Rockblox game control using hardware buttons
10643 Cowon D2: Chopper game control using hardware buttons
10644 Cowon D2: JPEG viewer control using hardware buttons an...
10645 Cowon D2: PNG viewer control using hardware buttons and...
10646 Cowon D2: Keyboard text input using hardware buttons an...
10647 Cowon D2: Time screen control using hardware buttons an...
10648 Cowon D2: Mpegplayer control using hardware buttons and...

Regards,
Tomer Shalev
Comment by Arago (Arago) - Saturday, 20 February 2010, 22:46 GMT+2
Okay, I can tell you my name, but I do not want to enter it into account information and assign it to my nick - I would like to preserve the anonymity in the Internet. This will be enough?
Comment by Tomer Shalev (tomers) - Sunday, 21 February 2010, 04:44 GMT+2
> Okay, I can tell you my name, but I do not want to enter it into account information and assign it to my nick - I would like to preserve the anonymity in the Internet. This will be enough?

This will be enough, but please notice that your full name will be shown in docs/CREDITS. I will not write your name in the commit log message, and will commit docs/CREDITS separately.
You can send me your name privately.
Comment by Arago (Arago) - Sunday, 21 February 2010, 10:55 GMT+2
Yes, i understand it.
I sent email to address in Your profile.

Loading...