- Status Closed
- Percent Complete
- Task Type Bugs
- Category Plugins
-
Assigned To
kkurbjun - Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#10568 - Brickmania Lasers not working properly
When playing brickmania, if one fires lasers from the paddle, then gets a ‘N’ or a ‘G’, those shots that were fired cease to work.
Closed by kkurbjun
2009-12-18 03:37
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2009-12-18 03:37
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Thanks!
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Just remove the ‘if’ from line 1181. (r22636)
By the way, I think that this loop is monstrous and not effective.
A diff file, in case that someone will commit it.
I still think that this loop have to been rewritten.
Asael,
Thanks for the patch, I will try to take a look at this later today, but offhand I think the fix looks appropriate. I agree that the game loop could definitely be re-written; it is not exactly efficient.
That loop has been changed some, at that patch is out of sync. Bug still present however.
It’s still a simple wrong “if”.
try the attached file. (I didn’t check it)