Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#10601 - Keyboard shortcuts to change backlight brightness

Attached to Project: Rockbox
Opened by Alex Suykov (alexs) - Friday, 11 September 2009, 21:22 GMT+2
Task Type Patches
Category LCD
Status Unconfirmed
Assigned To No-one
Player Type Sansa c200
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

The patch makes Rec+Vol{Up,Down} in wps and list (main menu) contexts chage backlight brighness. Just like with volume, brightness value is saved in config file. I find this feature quite useful when player is used both indoors and outdoors, eps. on sunny days.

Keymap changes are for Sansa C200 only. Check apps/keymaps/keymap-<you-target>.c and add necessary lines to button_context_{standard,wps} if you use different device.

Diff against SVN revision 22666.
   brightness.patch (3.9 KiB) 
 b/apps/action.h              |    2 ++
 b/apps/gui/list.c            |    8 ++++++++
 b/apps/gui/wps.c             |    6 ++++++
 b/apps/keymaps/keymap-c200.c |    5 +++++
 b/apps/misc.c                |   15 +++++++++++++++
 b/apps/misc.h                |    4 ++++
 6 files changed, 40 insertions(+)

This task depends upon

Comment by Marc Guay (Marc_Guay) - Saturday, 12 September 2009, 15:40 GMT+2
Why not just add LCD Brightness to the Quick Screen? http://download.rockbox.org/manual/rockbox-sansac200/rockbox-buildch5.html#x8-1030005.13
Comment by Alex Suykov (alexs) - Saturday, 12 September 2009, 18:20 GMT+2
Hm, wasn't aware it's configurable. Agreed, that might be viable alternative — less convenient as for me, but doesn't require patching.

Loading...