This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#10608 - Patch exposing pcmbuf_beep() to the Lua plugin
Attached to Project:
Rockbox
Opened by Christophe Gragnic (Grahack) - Tuesday, 15 September 2009, 18:30 GMT+2
Last edited by Maurus Cuelenaere (mcuelenaere) - Thursday, 29 October 2009, 17:52 GMT+2
Opened by Christophe Gragnic (Grahack) - Tuesday, 15 September 2009, 18:30 GMT+2
Last edited by Maurus Cuelenaere (mcuelenaere) - Thursday, 29 October 2009, 17:52 GMT+2
|
DetailsThis patch adds pcmbuf_beep() (found in pcmbuf.c) to the plugin API and exposes it to the Lua plugin.
Applies to r22699. issue #1: pcmbuf_beep doesn't beep when the music is paused because of a limitation of the playback system (http://www.rockbox.org/irc/log-20090915#17:55:56). issue #2: rb.beep(freq, duration, amplitude) crashes for duration > 3000 so maybe I should try to test the user params (I guess it's target/buffer/RAM dependant). 
pcmbuf_beep_to_lua.patch
(1.6 KiB)
apps/plugin.h | 3 +++ apps/plugin.c | 2 ++ apps/plugins/lua/rocklib.c | 10 ++++++++++ 3 files changed, 15 insertions(+) |
This task depends upon
Closed by Maurus Cuelenaere (mcuelenaere)
Thursday, 29 October 2009, 17:52 GMT+2
Reason for closing: Accepted
Additional comments about closing: In r23404.
Thursday, 29 October 2009, 17:52 GMT+2
Reason for closing: Accepted
Additional comments about closing: In r23404.
I suppose you don't mind me committing this with the function renamed to pcmbuf_beep()?
Also you need to increase PLUGIN_API_VERSION with 1 (not PLUGIN_MIN_API_VERSION).
Anyway a shortcut can easily be made in the Lua scripts (beep = pcmbuf_beep) for the lazy ones.
I'll try to provide a new patch in 24h for the API_VERSION thing, but feel free to not wait too.
Thanks